GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-133300: argparse: make `suggest_on_error` a keyword-only parameter by hugovk · Pull Request #133302 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented May 2, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: argparse: make suggest_on_error a keyword-only parameter #133300

📚 Documentation preview 📚: https://cpython-previews--133302.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk
Make suggest_on_error a keyword-only parameter
c2f844c
@hugovk hugovk added the type-feature A feature request or enhancement label May 2, 2025
@hugovk
hugovk requested a review from savannahostrowski as a code owner May 2, 2025 14:26
@bedevere-app bedevere-app Bot mentioned this pull request May 2, 2025
argparse: make suggest_on_error a keyword-only parameter #133300
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label May 2, 2025
tomasr8
tomasr8 approved these changes May 2, 2025
View reviewed changes

@tomasr8 tomasr8 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! suggest_on_error is new in 3.14 so we can safely make this change.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
serhiy-storchaka
serhiy-storchaka approved these changes May 2, 2025
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 2, 2025
@hugovk
hugovk merged commit e6c518d into python:main May 2, 2025
@hugovk
hugovk deleted the 3.14-argparse-keyword branch May 2, 2025 15:11
@bedevere-app bedevere-app Bot removed the awaiting merge label May 2, 2025
@edgarrmondragon edgarrmondragon mentioned this pull request May 6, 2025
Add new Python 3.14 argparse.ArgumentParser constructor parameters python/typeshed#13947
Merged
JelleZijlstra added a commit to python/typeshed that referenced this pull request May 12, 2025
@edgarrmondragon @srittau @JelleZijlstra
Add new Python 3.14 argparse.ArgumentParser constructor parameters (#…
3f8a48f 
…13947)

These are

- `suggest_on_error`, added by python/cpython#124456, made keyword-only by python/cpython#133302
- `color`, added by python/cpython#132323

Co-authored-by: Sebastian Rittau <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
mmingyu pushed a commit to mmingyu/typeshed that referenced this pull request May 16, 2025
@edgarrmondragon @srittau
@JelleZijlstra mingyu.park
Add new Python 3.14 argparse.ArgumentParser constructor parameters (p…
fc6a13f 
…ython#13947)

These are

- `suggest_on_error`, added by python/cpython#124456, made keyword-only by python/cpython#133302
- `color`, added by python/cpython#132323

Co-authored-by: Sebastian Rittau <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@hugovk @Pranjal095
pythongh-133300: argparse: make suggest_on_error a keyword-only par…
87ff45d 
…ameter (python#133302)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@tomasr8 tomasr8 tomasr8 approved these changes
@savannahostrowski savannahostrowski Awaiting requested review from savannahostrowski savannahostrowski is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@hugovk @serhiy-storchaka @tomasr8
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.