GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-126008: Improve docstrings for Tkinter cget and configure methods by serhiy-storchaka · Pull Request #133303 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented May 2, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Explain the behavior of Widget.configure() depending on arguments.
  • Unify descriptions.
  • Replace "resource" with "option".
  • Issue: Tkinter ttk widgets cget() returning _tkinter.Tcl_Obj instead of str #126008

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
pythongh-126008: Improve docstrings for Tkinter cget and configure me…
c7f9234 
…thods

* Explain the behavior of Widget.configure() depending on arguments.
* Unify descriptions.
* Replace "resource" with "option".
@serhiy-storchaka serhiy-storchaka added docs Documentation in the Doc dir skip news needs backport to 3.13 only security fixes labels May 2, 2025
@serhiy-storchaka
serhiy-storchaka requested a review from terryjreedy May 2, 2025 14:37
@github-project-automation github-project-automation Bot added this to Docs PRs May 2, 2025
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs May 2, 2025
@bedevere-app bedevere-app Bot mentioned this pull request May 2, 2025
Tkinter ttk widgets cget() returning _tkinter.Tcl_Obj instead of str #126008
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label May 2, 2025
tomasr8
tomasr8 reviewed May 2, 2025
View reviewed changes
Comment thread Lib/tkinter/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
terryjreedy
terryjreedy previously requested changes May 3, 2025
View reviewed changes
Comment thread Lib/tkinter/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/tkinter/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/tkinter/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/tkinter/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label May 3, 2025
@bedevere-app

bedevere-app Bot commented May 3, 2025

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added the awaiting changes label May 3, 2025
@serhiy-storchaka
Address some review comments.
c17b0db
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.14 bugs and security fixes label May 8, 2025
@serhiy-storchaka
serhiy-storchaka requested a review from a team May 13, 2025 10:36
@serhiy-storchaka
Merge branch 'main' into docs-tkinter-configure
3076927
bskinn
bskinn reviewed Jun 2, 2025
View reviewed changes
Comment thread Lib/tkinter/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/tkinter/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/tkinter/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/tkinter/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/tkinter/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka
serhiy-storchaka commented Aug 11, 2025
View reviewed changes
Comment thread Lib/tkinter/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/tkinter/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka and others added 2 commits August 11, 2025 09:31
@serhiy-storchaka @bskinn
Apply suggestions from code review
3e7b3d3 
Co-authored-by: Brian Skinn <[email protected]>
@serhiy-storchaka
Merge branch 'main' into docs-tkinter-configure
ba5b1cf
@terryjreedy
terryjreedy dismissed their stale review August 11, 2025 21:21

We agree that it would be better to have a separate issue/PR to handle option name formatting in docstrings in this entire file.

@bedevere-app bedevere-app Bot added awaiting review and removed awaiting changes labels Aug 11, 2025
@serhiy-storchaka
serhiy-storchaka merged commit 027cacb into python:main Aug 12, 2025
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Aug 12, 2025
@miss-islington-app

miss-islington-app Bot commented Aug 12, 2025

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting review label Aug 12, 2025
@serhiy-storchaka
serhiy-storchaka deleted the docs-tkinter-configure branch August 12, 2025 04:55
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 12, 2025
@serhiy-storchaka @miss-islington
pythongh-126008: Improve docstrings for Tkinter cget and configure me…
12f491a 
…thods (pythonGH-133303)

* Explain the behavior of Widget.configure() depending on arguments.
* Unify descriptions.
* Replace "resource" with "option".
(cherry picked from commit 027cacb)

Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 12, 2025
@serhiy-storchaka @miss-islington
pythongh-126008: Improve docstrings for Tkinter cget and configure me…
b2568e8 
…thods (pythonGH-133303)

* Explain the behavior of Widget.configure() depending on arguments.
* Unify descriptions.
* Replace "resource" with "option".
(cherry picked from commit 027cacb)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app

bedevere-app Bot commented Aug 12, 2025

Copy link
Copy Markdown

GH-137660 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Aug 12, 2025
@bedevere-app

bedevere-app Bot commented Aug 12, 2025

Copy link
Copy Markdown

GH-137661 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Aug 12, 2025
serhiy-storchaka added a commit that referenced this pull request Aug 12, 2025
@miss-islington @serhiy-storchaka
[3.13] gh-126008: Improve docstrings for Tkinter cget and configure m…
4a630d7 
…ethods (GH-133303) (GH-137661)

* Explain the behavior of Widget.configure() depending on arguments.
* Unify descriptions.
* Replace "resource" with "option".
(cherry picked from commit 027cacb)

Co-authored-by: Serhiy Storchaka <[email protected]>
@serhiy-storchaka

serhiy-storchaka commented Aug 12, 2025

Copy link
Copy Markdown
Member Author

Thank you for your review, @terryjreedy, @bskinn.
bskinn reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
maurycy added a commit to maurycy/cpython that referenced this pull request Aug 12, 2025
@maurycy
Merge branch 'main' into csv-sniffer-counter-set
11c891d 
* main:
  pythongh-137288: Update 3.14 magic numbers (pythonGH-137665)
  pythongh-135228: When @DataClass(slots=True) replaces a dataclass, make the original class collectible (take 2) (pythonGH-137047)
  pythongh-126008: Improve docstrings for Tkinter cget and configure methods (pythonGH-133303)
  pythongh-131885: Use positional-only markers for ``max()`` and ``min()`` (python#131868)
  pythonGH-137426: Remove code deprecation of `importlib.abc.ResourceLoader` (pythonGH-137567)
  pythongh-125897: Mark range function parameters as positional only (python#125945)
  pythongh-137400: Fix a crash when disabling profiling across all threads (pythongh-137471)
  pythongh-115766: Fix IPv4Interface.is_unspecified (pythonGH-137326)
  pythongh-128813: cleanup C-API docs for PyComplexObject (pythonGH-137579)
  pythongh-135953: Profile a module or script with sampling profiler (python#136777)
  Fix documentation of hash in PyHash_FuncDef (python#137595)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@serhiy-storchaka @Agent-Hellboy
pythongh-126008: Improve docstrings for Tkinter cget and configure me…
d7253bd 
…thods (pythonGH-133303)

* Explain the behavior of Widget.configure() depending on arguments.
* Unify descriptions.
* Replace "resource" with "option".
encukou pushed a commit that referenced this pull request Oct 7, 2025
@miss-islington @serhiy-storchaka
[3.14] gh-126008: Improve docstrings for Tkinter cget and configure m…
181cecc 
…ethods (GH-133303) (GH-137660)

* Explain the behavior of Widget.configure() depending on arguments.
* Unify descriptions.
* Replace "resource" with "option".
(cherry picked from commit 027cacb)

Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomasr8 tomasr8 tomasr8 left review comments
@AA-Turner AA-Turner AA-Turner left review comments
@terryjreedy terryjreedy terryjreedy left review comments
+1 more reviewer
@bskinn bskinn bskinn left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@serhiy-storchaka @tomasr8 @AA-Turner @bskinn @terryjreedy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.