GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-133273: Keep instruction definitions in `bytecodes.c` and `optimizer_bytecodes.c` in sync by tomasr8 · Pull Request #133320 · python/cpython

gh-133273: Keep instruction definitions in bytecodes.c and optimizer_bytecodes.c in sync #133320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fidget-Spinner merged 3 commits into python:main from tomasr8:validate-uops
May 8, 2025

Uh oh!

There was an error while loading. Please reload this page.

Merged

gh-133273: Keep instruction definitions in bytecodes.c and optimizer_bytecodes.c in sync #133320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a09150
Keep instruction definitions in bytecodes.c and optimizer_bytecodes.c…
tomasr8 May 2, 2025
8e5e19b
Also validate sizes
tomasr8 May 3, 2025
ffe5919
Merge remote-tracking branch 'upstream/main' into validate-uops
tomasr8 May 8, 2025
File filter
Filter by extension

Clear filters
Conversations
Failed to load comments.
Loading

Uh oh!

There was an error while loading. Please reload this page.

Jump to
Jump to file
Failed to load files.
Loading

Uh oh!

There was an error while loading. Please reload this page.

Diff view
Diff view

There are no files selected for viewing

183 changes: 183 additions & 0 deletions 183 Lib/test/test_generated_cases.py
Show comments
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2069,6 +2069,189 @@ def test_missing_override_failure(self):
with self.assertRaisesRegex(AssertionError, "All abstract uops"):
self.run_cases_test(input, input2, output)

def test_validate_uop_input_length_mismatch(self):
input = """
op(OP, (arg1 -- out)) {
SPAM();
}
"""
input2 = """
op(OP, (arg1, arg2 -- out)) {
}
"""
output = """
"""
with self.assertRaisesRegex(SyntaxError,
"Must have the same number of inputs"):
self.run_cases_test(input, input2, output)

def test_validate_uop_output_length_mismatch(self):
input = """
op(OP, (arg1 -- out)) {
SPAM();
}
"""
input2 = """
op(OP, (arg1 -- out1, out2)) {
}
"""
output = """
"""
with self.assertRaisesRegex(SyntaxError,
"Must have the same number of outputs"):
self.run_cases_test(input, input2, output)

def test_validate_uop_input_name_mismatch(self):
input = """
op(OP, (foo -- out)) {
SPAM();
}
"""
input2 = """
op(OP, (bar -- out)) {
}
"""
output = """
"""
with self.assertRaisesRegex(SyntaxError,
"Inputs must have equal names"):
self.run_cases_test(input, input2, output)

def test_validate_uop_output_name_mismatch(self):
input = """
op(OP, (arg1 -- foo)) {
SPAM();
}
"""
input2 = """
op(OP, (arg1 -- bar)) {
}
"""
output = """
"""
with self.assertRaisesRegex(SyntaxError,
"Outputs must have equal names"):
self.run_cases_test(input, input2, output)

def test_validate_uop_unused_input(self):
input = """
op(OP, (unused -- )) {
}
"""
input2 = """
op(OP, (foo -- )) {
}
"""
output = """
case OP: {
stack_pointer += -1;
assert(WITHIN_STACK_BOUNDS());
break;
}
"""
self.run_cases_test(input, input2, output)

input = """
op(OP, (foo -- )) {
}
"""
input2 = """
op(OP, (unused -- )) {
}
"""
output = """
case OP: {
stack_pointer += -1;
assert(WITHIN_STACK_BOUNDS());
break;
}
"""
self.run_cases_test(input, input2, output)

def test_validate_uop_unused_output(self):
input = """
op(OP, ( -- unused)) {
}
"""
input2 = """
op(OP, ( -- foo)) {
foo = NULL;
}
"""
output = """
case OP: {
JitOptSymbol *foo;
foo = NULL;
stack_pointer[0] = foo;
stack_pointer += 1;
assert(WITHIN_STACK_BOUNDS());
break;
}
"""
self.run_cases_test(input, input2, output)

input = """
op(OP, ( -- foo)) {
foo = NULL;
}
"""
input2 = """
op(OP, ( -- unused)) {
}
"""
output = """
case OP: {
stack_pointer += 1;
assert(WITHIN_STACK_BOUNDS());
break;
}
"""
self.run_cases_test(input, input2, output)

def test_validate_uop_input_size_mismatch(self):
input = """
op(OP, (arg1[2] -- )) {
}
"""
input2 = """
op(OP, (arg1[4] -- )) {
}
"""
output = """
"""
with self.assertRaisesRegex(SyntaxError,
"Inputs must have equal sizes"):
self.run_cases_test(input, input2, output)

def test_validate_uop_output_size_mismatch(self):
input = """
op(OP, ( -- out[2])) {
}
"""
input2 = """
op(OP, ( -- out[4])) {
}
"""
output = """
"""
with self.assertRaisesRegex(SyntaxError,
"Outputs must have equal sizes"):
self.run_cases_test(input, input2, output)

def test_validate_uop_unused_size_mismatch(self):
input = """
op(OP, (foo[2] -- )) {
}
"""
input2 = """
op(OP, (unused[4] -- )) {
}
"""
output = """
"""
with self.assertRaisesRegex(SyntaxError,
"Inputs must have equal sizes"):
self.run_cases_test(input, input2, output)

if __name__ == "__main__":
unittest.main()
Loading
Oops, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.