GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-131798: JIT: Narrow the return type of `_GET_LEN` to int by Zheaoli · Pull Request #133345 · python/cpython

Conversation

Zheaoli commented May 3, 2025 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Signed-off-by: Manjusaka [email protected]

Issue: Better uop coverage in the JIT optimizer #131798

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Zheaoli requested a review from Fidget-Spinner as a code owner

May 3, 2025 14:32

bedevere-app Bot mentioned this pull request

May 3, 2025

Better uop coverage in the JIT optimizer #131798

Open

bedevere-app Bot added the awaiting review label

May 3, 2025

tomasr8 reviewed

May 3, 2025

View reviewed changes

Comment thread

Lib/test/test_capi/test_opt.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

ZeroIntensity added the topic-JIT label

May 3, 2025

Fidget-Spinner approved these changes

May 4, 2025

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting review labels

May 4, 2025

brandtbucher requested changes

May 6, 2025

View reviewed changes

Comment thread

Lib/test/test_capi/test_opt.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Python/optimizer_bytecodes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Python/optimizer_bytecodes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting merge label

May 6, 2025

bedevere-app Bot commented May 6, 2025

Copy link

Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot added the awaiting changes label

May 6, 2025

Zheaoli added 5 commits

May 8, 2025 15:03


          pythongh-131798: JIT: Narrow the return type of _GET_LEN to int

cabe8f1

Signed-off-by: Manjusaka <[email protected]>


          Add news

1f8a607

Signed-off-by: Manjusaka <[email protected]>


          Fix typo

f2f71d9

Signed-off-by: Manjusaka <[email protected]>


          Fix review idea

1662b47

Signed-off-by: Manjusaka <[email protected]>


          Fix review idea

52ce698

Signed-off-by: Manjusaka <[email protected]>

Zheaoli force-pushed the manjusaka/get-len branch from ad1f5df to 52ce698 Compare

May 8, 2025 07:07


          Fix review idea

b1640ed

Signed-off-by: Manjusaka <[email protected]>

Zheaoli commented May 8, 2025

Copy link

Copy Markdown

Contributor Author

I have made the requested changes; please review again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot added awaiting change review and removed awaiting changes labels

May 8, 2025

bedevere-app Bot commented May 8, 2025

Copy link

Copy Markdown

Thanks for making the requested changes!

@Fidget-Spinner, @brandtbucher: please review the changes made to this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot requested review from Fidget-Spinner and brandtbucher

May 8, 2025 07:46

Zheaoli commented May 8, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor Author

BTW @brandtbucher @Fidget-Spinner sorry about the force push. I set pull with rebase as default on my environment. I will modify it in next PR(

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

brandtbucher requested changes

May 8, 2025

View reviewed changes

Comment thread

Python/optimizer_bytecodes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Python/optimizer_bytecodes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot added awaiting changes and removed awaiting change review labels

May 8, 2025

bedevere-app Bot commented May 8, 2025

Copy link

Copy Markdown

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Zheaoli added 4 commits

May 21, 2025 04:12


          fix review idea

d1e3a2b

Signed-off-by: Manjusaka <[email protected]>


          fix review idea

e0e3745

Signed-off-by: Manjusaka <[email protected]>


          fix review idea

81c4996

Signed-off-by: Manjusaka <[email protected]>


          fix review idea

93e1e86

Signed-off-by: Manjusaka <[email protected]>

Zheaoli commented May 20, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor Author

I have made the requested changes; please review again

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot added awaiting change review and removed awaiting changes labels

May 20, 2025

bedevere-app Bot commented May 20, 2025

Copy link

Copy Markdown

Thanks for making the requested changes!

@Fidget-Spinner, @brandtbucher: please review the changes made to this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot requested a review from brandtbucher

May 20, 2025 20:21


          fix review idea

6b5282f

Signed-off-by: Manjusaka <[email protected]>

tomasr8 reviewed

May 20, 2025

View reviewed changes

Comment thread

Lib/test/test_capi/test_opt.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Zheaoli added 2 commits

May 21, 2025 04:59


          fix review idea

2eefeb3

Signed-off-by: Manjusaka <[email protected]>


          fix review idea

9c58f2c

Signed-off-by: Manjusaka <[email protected]>

brandtbucher approved these changes

May 20, 2025

View reviewed changes

brandtbucher left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one last suggestion for the test:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Lib/test/test_capi/test_opt.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot added awaiting merge and removed awaiting change review labels

May 20, 2025

Zheaoli added 3 commits

May 21, 2025 05:13


          fix review idea

f9822e9

Signed-off-by: Manjusaka <[email protected]>


          fix review idea

6a06aff

Signed-off-by: Manjusaka <[email protected]>


          fix review idea

6d92614

Signed-off-by: Manjusaka <[email protected]>

Zheaoli requested a review from brandtbucher

May 20, 2025 21:14


          format code

5cfbad4

Signed-off-by: Manjusaka <[email protected]>

brandtbucher approved these changes

May 20, 2025

View reviewed changes

Zheaoli commented May 20, 2025

Copy link

Copy Markdown

Contributor Author

Looks good! Just one last suggestion for the test:

Thanks for your patience and review. Learn a lot in this PR. I think I can find a new opcode to write! Thanks again ♥️ @brandtbucher @tomasr8

tomasr8 reacted with heart emoji

All reactions

❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

brandtbucher merged commit e1c0c45 into python:main

May 20, 2025

bedevere-app Bot removed the awaiting merge label

May 20, 2025

Zheaoli deleted the manjusaka/get-len branch

May 20, 2025 22:23

lkollar pushed a commit to lkollar/cpython that referenced this pull request

May 26, 2025


          pythonGH-131798: Narrow the return type of _GET_LEN to int (pythonGH-…

274e5d5

…133345)

Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request

Jul 12, 2025


          pythonGH-131798: Narrow the return type of _GET_LEN to int (pythonGH-…

6ddc201

…133345)

taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request

Aug 4, 2025


          pythonGH-131798: Narrow the return type of _GET_LEN to int (pythonGH-…

fbb8996

…133345)

gostak-dd pushed a commit to gostak-dd/cpython that referenced this pull request

Jun 2, 2026


          pythonGH-131798: Narrow the return type of _GET_LEN to int (pythonGH-…

b8e48ba

…133345)

Reviewers

tomasr8

tomasr8 left review comments

brandtbucher

brandtbucher approved these changes

Fidget-Spinner

Awaiting requested review from Fidget-Spinner

Fidget-Spinner is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-JIT

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

Zheaoli commented May 3, 2025 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-app Bot commented May 6, 2025

Uh oh!

Zheaoli commented May 8, 2025

Uh oh!

bedevere-app Bot commented May 8, 2025

Uh oh!

Zheaoli commented May 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-app Bot commented May 8, 2025

Uh oh!

Zheaoli commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-app Bot commented May 20, 2025

Uh oh!

Uh oh!

brandtbucher left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Zheaoli commented May 20, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Zheaoli commented May 3, 2025 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Zheaoli commented May 8, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Zheaoli commented May 20, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.