GeezerVison is showing github.com — [GH-133419] fix test_external_inspection race assert by gpshead · Pull Request #133422 · python/cpython
Conversation
gpshead
commented
May 5, 2025
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
either line could be where the inspection finds the foo() function as after ready is sent, the process may not have made progress onto the next line yet. "solve" by putting the statements on the same line. simpler than asserting for multiple possible line values.
Fixes #133419.
Closes #133419.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
either line could be where the inspection finds the foo()
function as after ready is sent, the process may not have made progress
onto the next line yet. "solve" by putting the statements on the same
line.
|
This change doesn't fix all tests, it's incomplete. I wrote #133433 to fix more tests.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
…3422)
[tests] fix test_external_inspection race assert
either line could be where the inspection finds the foo()
function as after ready is sent, the process may not have made progress
onto the next line yet. "solve" by putting the statements on the same
line.
Reviewers
pablogsal
Awaiting requested review from pablogsal
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.