GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Revert "gh-124715: Fix method_dealloc(): use PyObject_GC_UnTrack() (#133199)" by vstinner · Pull Request #133434 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented May 5, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This reverts commit 662dd29.

The root issue was fixed by the commit f554237.

  • Issue: Not all types have "trashcan" protection and tp_dealloc can overflow stack #124715

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
Revert "pythongh-124715: Fix method_dealloc(): use PyObject_GC_UnTrac…
7ce29b0 
…k() (python#133199)"

This reverts commit 662dd29.

The root issue was fixed by the
commit f554237.
@vstinner vstinner added the skip news label May 5, 2025
@bedevere-app bedevere-app Bot mentioned this pull request May 5, 2025
Not all types have "trashcan" protection and tp_dealloc can overflow stack #124715
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label May 5, 2025
@vstinner
vstinner merged commit c336f1c into python:main May 5, 2025
@vstinner
vstinner deleted the revert_method branch May 5, 2025 15:04
@bedevere-app bedevere-app Bot removed the awaiting core review label May 5, 2025
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@vstinner @Pranjal095
Revert "pythongh-124715: Fix method_dealloc(): use PyObject_GC_UnTrac…
ad5f435 
…k() (python#133199)" (python#133434)

This reverts commit 662dd29.

The root issue was fixed by the
commit f554237.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.