GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-133261: Make sure trashcan pointers look mortal -- 32 bit by markshannon · Pull Request #133450 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented May 5, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: test_frame does crash randomly on Linux (x86-64, ppc64le, s390x) #133261

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@markshannon
Make sure trashcan pointer look mortal -- 32 bit
2ef7ee5
@bedevere-app bedevere-app Bot mentioned this pull request May 5, 2025
test_frame does crash randomly on Linux (x86-64, ppc64le, s390x) #133261
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label May 5, 2025
@markshannon markshannon added the skip news label May 5, 2025
@markshannon
markshannon requested a review from vstinner May 5, 2025 16:30
@markshannon

markshannon commented May 5, 2025

Copy link
Copy Markdown
Member Author

!buildbot "x86 Debian"
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented May 5, 2025

Copy link
Copy Markdown

The regex '"x86 Debian"' did not match any buildbot builder. Is the requested builder in the list of stable builders?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@markshannon

markshannon commented May 5, 2025

Copy link
Copy Markdown
Member Author

!buildbot x86 Debian
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented May 5, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @markshannon for commit 2ef7ee5 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133450%2Fmerge

The command will test the builders whose names match following regular expression: x86 Debian

The builders matched are:

  • x86 Debian Non-Debug with X PR
  • x86 Debian Installed with X PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@markshannon markshannon changed the title GH-133261: Make sure trashcan pointer look mortal -- 32 bit GH-133261: Make sure trashcan pointers look mortal -- 32 bit May 5, 2025
vstinner
vstinner approved these changes May 5, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Objects/object.c
}
return (void *)(refcnt - 2);
#else
return (void *)((refcnt -1) << 2);

@vstinner vstinner May 5, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return (void *)((refcnt -1) << 2);
return (void *)((refcnt - 1) << 2);

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 5, 2025
@vstinner

vstinner commented May 5, 2025

Copy link
Copy Markdown
Member

buildbot/x86 Debian Installed with X PR — Build done.
buildbot/x86 Debian Non-Debug with X PR — Build done.

Nice, the fix works as expected, tests passed on two buildbot workers.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented May 5, 2025

Copy link
Copy Markdown
Member

I built Python using CFLAGS=-m32 (on Linux x86-64) but I failed to reproduce the issue.

I built Python in a x86 (32-bit) container, but I failed to reproduce the issue.

But this change looks correct, it should fix the issue, and the buildbots confirmed that the fix works.
efimov-mikhail reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv
ambv merged commit d48616e into python:main May 5, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label May 5, 2025
@markshannon
markshannon deleted the fix-133261-32bit branch May 6, 2025 08:22
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@markshannon @Pranjal095
pythonGH-133261: Make sure trashcan pointers look mortal -- 32 bit (p…
8153f7b 
…ythonGH-133450)

Make sure trashcan pointer look mortal -- 32 bit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@markshannon @bedevere-bot @vstinner @ambv
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.