GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-132983: Use a standard autoconf version check for zstd by AA-Turner · Pull Request #133479 · python/cpython

Conversation

@AA-Turner

@AA-Turner AA-Turner commented May 5, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

cc @ned-deily, it seems that this works & is simpler? I'll run buildbots.

A

  • Issue: Implement PEP 784 - Adding Zstandard to the Python standard library #132983

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AA-Turner
Use a standard version check
afbc562
@AA-Turner
AA-Turner requested review from corona10 and erlend-aasland as code owners May 5, 2025 23:20
@bedevere-app bedevere-app Bot mentioned this pull request May 5, 2025
Implement PEP 784 - Adding Zstandard to the Python standard library #132983
Closed
13 tasks done
@bedevere-app bedevere-app Bot added the awaiting core review label May 5, 2025
@AA-Turner AA-Turner added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 5, 2025
@bedevere-bot

bedevere-bot commented May 5, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @AA-Turner for commit afbc562 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133479%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 5, 2025
@ned-deily

ned-deily commented May 5, 2025

Copy link
Copy Markdown
Member

@AA-Turner That looks promising: it seems to handle my use case. Thanks!

cc: @emmatyping
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ned-deily

ned-deily commented May 5, 2025

Copy link
Copy Markdown
Member

... and the ghcr.io/cirruslabs/macos-runner:sonoma runner also now appears to successfully build _zstd.
emmatyping reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
emmatyping
emmatyping approved these changes May 5, 2025
View reviewed changes

@emmatyping emmatyping left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I didn't know this was something one could do. TIL

I'd like to wait for a RHEL8 buildbot to go green before merging to ensure that it works when there is a version of libzstd that is too old. Otherwise it looks much better.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@emmatyping

emmatyping commented May 5, 2025

Copy link
Copy Markdown
Member

And thank you for catching the original issue @ned-deily !
ned-deily reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ned-deily

ned-deily commented May 5, 2025

Copy link
Copy Markdown
Member

I didn't know this was something one could do.

There is always something in Autotools that no one knows you can do.
erlend-aasland reacted with thumbs up emoji emmatyping reacted with laugh emoji
All reactions
  • 👍 1 reaction
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner AA-Turner added the skip news label May 6, 2025
@AA-Turner

AA-Turner commented May 6, 2025

Copy link
Copy Markdown
Member Author

https://buildbot.python.org/#/builders/170/builds/1765

checking for libzstd >= 1.4.5... no
checking for zstd.h... no
checking for zdict.h... no
...
checking for stdlib extension module _zstd... missing

Seems to work.

A
emmatyping reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
AA-Turner requested a review from emmatyping May 6, 2025 00:29
@AA-Turner
AA-Turner merged commit 793402e into python:main May 6, 2025
@bedevere-app bedevere-app Bot removed the awaiting core review label May 6, 2025
@AA-Turner
AA-Turner deleted the zstd-conf branch May 6, 2025 00:35
@emmatyping emmatyping mentioned this pull request May 6, 2025
gh-132983: Introduce _zstd bindings module #133027
Merged
4 tasks done
emmatyping added a commit to emmatyping/cpython that referenced this pull request May 7, 2025
@emmatyping
Support finding libzstd not in pkg-config
f3dd7f7 
pythonGH-133479 removed the logic to check for libzstd outside of pkg-config.
This commit adds that logic back with a check for the version so that
users can provide their own libzstd. This is to bring parity with lzma,
bz2, and zlib detection.
@emmatyping emmatyping mentioned this pull request May 7, 2025
GH-132983: Support finding libzstd without pkg-config #133550
Closed
emmatyping added a commit to emmatyping/cpython that referenced this pull request May 12, 2025
@emmatyping
Support finding libzstd not in pkg-config
a5c20a8 
pythonGH-133479 removed the logic to check for libzstd outside of pkg-config.
This commit adds that logic back with a check for the version so that
users can provide their own libzstd. This is to bring parity with lzma,
bz2, and zlib detection.
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@AA-Turner @Pranjal095
pythonGH-132983: Use a standard autoconf version check for zstd (pyth…
d905181 
…on#133479)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner
@emmatyping emmatyping Awaiting requested review from emmatyping emmatyping is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@AA-Turner @bedevere-bot @ned-deily @emmatyping
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.