GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-81793: Replace skip decorators with specific helpers by zware · Pull Request #133493 · python/cpython

Conversation

@zware

@zware zware commented May 6, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This should fix failure on the AMD64 Windows11 Non-Debug 3.x buildbot.

  • Issue: os.link(..., follow_symlinks=True) broken on Linux #81793

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zware
pythongh-81793: Replace skip decorators with specific helpers
dd0384f
@zware
zware requested a review from chris-eibl May 6, 2025 05:33
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label May 6, 2025
@bedevere-app bedevere-app Bot mentioned this pull request May 6, 2025
os.link(..., follow_symlinks=True) broken on Linux #81793
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label May 6, 2025
@zware zware added the skip news label May 6, 2025
chris-eibl
chris-eibl approved these changes May 6, 2025
View reviewed changes

@chris-eibl chris-eibl left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Tested on Windows: as a regular user, the test is skipped, and in an admin shell the test is executed (and succeeds)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
zware reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@zware
zware enabled auto-merge (squash) May 6, 2025 05:37
@zware
zware merged commit 5b07c6e into python:main May 6, 2025
@zware
zware deleted the fix_link_test branch May 6, 2025 05:58
@bedevere-app bedevere-app Bot removed the awaiting core review label May 6, 2025
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@zware @Pranjal095
pythongh-81793: Replace skip decorators with specific helpers (python…
f8c5dc8 
…GH-133493)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chris-eibl chris-eibl chris-eibl approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@zware @chris-eibl
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.