GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-131178: Add tests for `site` command-line interface by ggqlq · Pull Request #133582 · python/cpython

Conversation

@ggqlq

@ggqlq ggqlq commented May 7, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Add tests for command-line interface #131178

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ggqlq added 3 commits May 7, 2025 22:35
@ggqlq
pythongh-131178: Add tests for command-line interface
fc36305
@ggqlq
pythongh-131178: Add tests for site command-line interface
6497282
@ggqlq
pythongh-131178: Add tests for site command-line interface
b1ec14d
@ggqlq
ggqlq requested a review from FFY00 as a code owner May 7, 2025 14:41
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label May 7, 2025
@bedevere-app bedevere-app Bot mentioned this pull request May 7, 2025
Add tests for command-line interface #131178
Open
7 of 9 tasks
@bedevere-app

This comment was marked as resolved.

Sign in to view
@bedevere-app bedevere-app Bot added the awaiting review label May 7, 2025
@ggqlq
ggqlq marked this pull request as draft May 7, 2025 16:09
@bedevere-app bedevere-app Bot removed the awaiting review label May 7, 2025
@bedevere-app

This comment was marked as resolved.

Sign in to view
4 similar comments
@bedevere-app

This comment was marked as resolved.

Sign in to view
@bedevere-app

This comment was marked as resolved.

Sign in to view
@bedevere-app

This comment was marked as resolved.

Sign in to view
@bedevere-app

This comment was marked as resolved.

Sign in to view
@ggqlq
ggqlq force-pushed the add_tests_for_site_cli branch from bd612e2 to b1ec14d Compare May 7, 2025 19:00
@bedevere-app

This comment was marked as resolved.

Sign in to view
@ggqlq
Merge branch 'main' into add_tests_for_site_cli
1091b8d
@bedevere-app

This comment was marked as resolved.

Sign in to view
@ggqlq
fix
6e8d75e
@bedevere-app

This comment was marked as resolved.

Sign in to view
ggqlq added 2 commits May 8, 2025 13:44
@ggqlq
fix windows
3c1ba46
@ggqlq
fix windows
98145f6
@bedevere-app

This comment was marked as resolved.

Sign in to view
@ggqlq
ggqlq marked this pull request as ready for review May 8, 2025 06:51
@bedevere-app bedevere-app Bot added the awaiting review label May 8, 2025
@ZeroIntensity ZeroIntensity added the skip news label May 11, 2025
ZeroIntensity
ZeroIntensity reviewed May 11, 2025
View reviewed changes
Comment thread Lib/test/test_site.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_site.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_site.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_site.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ZeroIntensity

ZeroIntensity commented May 11, 2025

Copy link
Copy Markdown
Member

Also: don't force push, it just makes reviewing harder and the bot louder. We squash-merge at the end.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ggqlq
update
d36397b
@ggqlq
ggqlq requested a review from ZeroIntensity May 13, 2025 06:59
ggqlq added 4 commits May 25, 2025 10:15
@ggqlq
Merge branch 'main' into add_tests_for_site_cli
9bc46bc
@ggqlq
Merge branch 'main' into add_tests_for_site_cli
24bdf3f
@ggqlq
Merge branch 'main' into add_tests_for_site_cli
1a8f291
@ggqlq
Merge branch 'main' into add_tests_for_site_cli
d0999d2
@ZeroIntensity ZeroIntensity added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 5, 2025
@bedevere-bot

bedevere-bot commented Jun 5, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ZeroIntensity for commit d0999d2 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133582%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 5, 2025
@ggqlq
Merge branch 'main' into add_tests_for_site_cli
e9824d8
@donbarbos donbarbos mentioned this pull request Aug 15, 2025
gh-131178: Add tests for site command-line interface #137807
Closed
@ZeroIntensity
Merge branch 'main' into add_tests_for_site_cli
d5fb77c
ZeroIntensity
ZeroIntensity approved these changes Aug 15, 2025
View reviewed changes

@ZeroIntensity ZeroIntensity left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Aug 15, 2025
@ZeroIntensity ZeroIntensity added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Aug 15, 2025
@ZeroIntensity
ZeroIntensity merged commit 03f5519 into python:main Aug 15, 2025
@miss-islington-app

miss-islington-app Bot commented Aug 15, 2025

Copy link
Copy Markdown

Thanks @ggqlq for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Aug 15, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 15, 2025
@ggqlq @miss-islington
pythongh-131178: Add tests for site command-line interface (pythonG…
2efeb8f 
…H-133582)

(cherry picked from commit 03f5519)

Co-authored-by: ggqlq <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 15, 2025
@ggqlq @miss-islington
pythongh-131178: Add tests for site command-line interface (pythonG…
797f64e 
…H-133582)

(cherry picked from commit 03f5519)

Co-authored-by: ggqlq <[email protected]>
@bedevere-app

bedevere-app Bot commented Aug 15, 2025

Copy link
Copy Markdown

GH-137832 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Aug 15, 2025
@bedevere-app

bedevere-app Bot commented Aug 15, 2025

Copy link
Copy Markdown

GH-137833 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Aug 15, 2025
ZeroIntensity pushed a commit that referenced this pull request Aug 15, 2025
@miss-islington @ggqlq
[3.13] gh-131178: Add tests for site command-line interface (GH-133582
8d6e107 
) (GH-137833)

gh-131178: Add tests for `site` command-line interface  (GH-133582)
(cherry picked from commit 03f5519)

Co-authored-by: ggqlq <[email protected]>
@ggqlq

ggqlq commented Aug 18, 2025

Copy link
Copy Markdown
Contributor Author

@ZeroIntensity Thank you for your review!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@ggqlq @Agent-Hellboy
pythongh-131178: Add tests for site command-line interface (python…
ed3b781 
…GH-133582)
ZeroIntensity pushed a commit that referenced this pull request Oct 7, 2025
@miss-islington @ggqlq
[3.14] gh-131178: Add tests for site command-line interface (GH-133582
df739f3 
) (GH-137832)

gh-131178: Add tests for `site` command-line interface  (GH-133582)
(cherry picked from commit 03f5519)

Co-authored-by: ggqlq <[email protected]>
@itamaro itamaro mentioned this pull request Oct 15, 2025
New test_site tests fail with -s interpreter flag #140170
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes
@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ggqlq @ZeroIntensity @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.