GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-133610: Remove PyUnicode_AsDecoded/Encoded functions by StanFromIreland · Pull Request #133612 · python/cpython

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented May 7, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

📚 Documentation preview 📚: https://cpython-previews--133612.org.readthedocs.build/

  • Issue: Remove deprecated PyUnicode_AsDecoded/Encoded functions #133610

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
StanFromIreland added 2 commits May 7, 2025 21:19
@StanFromIreland
Remove
ba299e0
@StanFromIreland
Fixup
602b834
@StanFromIreland
StanFromIreland requested a review from encukou as a code owner May 7, 2025 20:21
@bedevere-app bedevere-app Bot added the awaiting review label May 7, 2025
@StanFromIreland StanFromIreland changed the title Remove PyUnicode_AsDecoded/Encoded functions gh-133610: Remove PyUnicode_AsDecoded/Encoded functions May 7, 2025
@bedevere-app bedevere-app Bot mentioned this pull request May 7, 2025
Remove deprecated PyUnicode_AsDecoded/Encoded functions #133610
Closed
@StanFromIreland
Fixup
a6ac1e9
@StanFromIreland

StanFromIreland commented May 8, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

cc @AA-Turner , @emmatyping for test_zstd fail https://github.com/python/cpython/actions/runs/14894216754/job/41833346355?pr=133612
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland
Merge branch 'main' into rem-depr-uni-c-api
bbcb04e
@StanFromIreland

StanFromIreland commented May 8, 2025

Copy link
Copy Markdown
Member Author

Request: @vstinner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner reviewed May 8, 2025
View reviewed changes
Comment thread Doc/deprecations/c-api-pending-removal-in-3.15.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.15.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland
Victors Review
ea33f91
@StanFromIreland
StanFromIreland requested a review from vstinner May 8, 2025 15:02
@StanFromIreland
Docs fixup
4d948c0
vstinner
vstinner reviewed May 8, 2025
View reviewed changes
Comment thread Doc/whatsnew/3.15.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread .editorconfig Resolved

Uh oh!

There was an error while loading. Please reload this page.
StanFromIreland added 2 commits May 8, 2025 16:59
@StanFromIreland
Cleanup
bb36c54
@StanFromIreland
revert removal
f2f51cc
vstinner
vstinner approved these changes May 8, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels May 8, 2025
@vstinner

vstinner commented May 9, 2025

Copy link
Copy Markdown
Member

Tests / Ubuntu (free-threading) / build and test (ubuntu-24.04) (pull_request)

test_zstd crash:

0:12:55 load avg: 14.73 [1/3/1] test_zstd worker non-zero exit code (Exit code -11 (SIGSEGV))
Re-running test_zstd in verbose mode (matching: test_compress_locking)
test_compress_locking (test.test_zstd.FreeThreadingMethodTests.test_compress_locking) ...

Fatal Python error: Fatal Python error: Segmentation faultSegmentation fault
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented May 9, 2025

Copy link
Copy Markdown
Member

A code search on PyPI top 8,000 projects found 2 projects, but there are only references to these 4 removed functions, these functions are not actually used. So we should be good in terms of impact.
StanFromIreland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 4fd1095 into python:main May 9, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label May 9, 2025
@StanFromIreland
StanFromIreland deleted the rem-depr-uni-c-api branch May 9, 2025 15:33
@emmatyping

emmatyping commented May 9, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@vstinner @StanFromIreland the zstd crash is noted in #132983 (comment). I'm still trying to figure out the cause/fix for it.
vstinner reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@StanFromIreland @Pranjal095
pythongh-133610: Remove PyUnicode_AsDecoded/Encoded functions (python…
f38f2be 
…#133612)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@StanFromIreland @taegyunkim
pythongh-133610: Remove PyUnicode_AsDecoded/Encoded functions (python…
1675141 
…#133612)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@encukou encukou Awaiting requested review from encukou encukou is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@StanFromIreland @vstinner @emmatyping
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.