GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-133644: remove deprecated `PyImport_ImportModuleNoBlock` by picnixz · Pull Request #133655 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented May 8, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Remove deprecated C API objects slated for removal in 3.15 #133644

📚 Documentation preview 📚: https://cpython-previews--133655.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@picnixz
remove PyImport_ImportModuleNoBlock
1a68caa
@picnixz
picnixz requested review from a team, brettcannon, encukou, ericsnowcurrently, kumaraditya303, ncoghlan and warsaw as code owners May 8, 2025 10:28
@bedevere-app bedevere-app Bot mentioned this pull request May 8, 2025
Remove deprecated C API objects slated for removal in 3.15 #133644
Open
6 of 9 tasks
@bedevere-app bedevere-app Bot added the awaiting core review label May 8, 2025
picnixz added 3 commits May 8, 2025 12:35
@picnixz
update refs
11b6f07
@picnixz
restore file
8b7a020
@picnixz
restore stable ABI symbols
a4c7ca3
vstinner
vstinner reviewed May 8, 2025
View reviewed changes
Comment thread Modules/_testlimitedcapi/import.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.15.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented May 8, 2025

Copy link
Copy Markdown
Member

A search on PyPI top 8,000 projects found usage in 2 projects:

  • dukpy (0.5.0)
  • google-cloud-profiler (4.1.0)
dukpy-0.5.0.tar.gz: dukpy-0.5.0/src/capsulethunk.h: object = PyImport_ImportModuleNoBlock(trace);

google-cloud-profiler-4.1.0.tar.gz: google-cloud-profiler-4.1.0/googlecloudprofiler/src/log.cc: logging = PyImport_ImportModuleNoBlock("logging");
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
picnixz added 2 commits May 8, 2025 14:37
@picnixz
update ABI imports
87697cf
@picnixz
update docs
07a28c9
vstinner
vstinner approved these changes May 8, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 8, 2025
@picnixz
picnixz enabled auto-merge (squash) May 8, 2025 12:57
@picnixz
picnixz merged commit a2c4467 into python:main May 8, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label May 8, 2025
@picnixz
picnixz deleted the cleanup/315/deprecated-import-133644 branch May 8, 2025 13:13
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@picnixz @Pranjal095
pythongh-133644: remove deprecated PyImport_ImportModuleNoBlock (py…
b218a11 
…thon#133655)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@picnixz @taegyunkim
pythongh-133644: remove deprecated PyImport_ImportModuleNoBlock (py…
25fae29 
…thon#133655)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@encukou encukou Awaiting requested review from encukou encukou is a code owner
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner
@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@picnixz @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.