GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-132983: Make zstd types immutable by AA-Turner · Pull Request #133784 · python/cpython

Conversation

AA-Turner commented May 9, 2025 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

I haven't added tests as the other modules don't seem to have any for immutable types, but happy to do so if wanted.

Issue: Implement PEP 784 - Adding Zstandard to the Python standard library #132983

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Make zstd types immutable

9be36ca

AA-Turner requested review from emmatyping, picnixz and serhiy-storchaka

May 9, 2025 19:25

AA-Turner added the skip news label

May 9, 2025

bedevere-app Bot mentioned this pull request

May 9, 2025

Implement PEP 784 - Adding Zstandard to the Python standard library #132983

Closed

13 tasks done

bedevere-app Bot added the awaiting core review label

May 9, 2025

AA-Turner mentioned this pull request

May 9, 2025

gh-132983: Simplify _zstd_exec() #133775

Merged

picnixz reviewed

May 9, 2025

View reviewed changes

Comment thread

Modules/_zstd/_zstdmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

AA-Turner added the needs backport to 3.14 bugs and security fixes label

May 9, 2025

serhiy-storchaka approved these changes

May 10, 2025

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting core review labels

May 10, 2025

emmatyping approved these changes

May 10, 2025

View reviewed changes

AA-Turner added 2 commits

May 10, 2025 23:09


          Merge remote-tracking branch 'upstream/main' into zstd-immutable-types

563706a


          Add comment

a02c427

AA-Turner enabled auto-merge (squash)

May 10, 2025 22:12

AA-Turner merged commit 1a87b6e into python:main

May 10, 2025

miss-islington-app Bot commented May 10, 2025

Copy link

Copy Markdown

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting merge label

May 10, 2025

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

May 10, 2025


          pythongh-132983: Make zstd types immutable (pythonGH-133784)

4146ed7

(cherry picked from commit 1a87b6e)

Co-authored-by: Adam Turner <[email protected]>

bedevere-app Bot commented May 10, 2025

Copy link

Copy Markdown

GH-133857 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label

May 10, 2025

AA-Turner deleted the zstd-immutable-types branch

May 10, 2025 22:56

AA-Turner added a commit that referenced this pull request

May 10, 2025


          [3.14] gh-132983: Make zstd types immutable (GH-133784) (#133857)

1e8a534

gh-132983: Make zstd types immutable (GH-133784)
(cherry picked from commit 1a87b6e)

Co-authored-by: Adam Turner <[email protected]>

Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request

Jul 12, 2025


          pythongh-132983: Make zstd types immutable (python#133784)

5acf5e4

taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request

Aug 4, 2025


          pythongh-132983: Make zstd types immutable (python#133784)

94d7f43

scasella mentioned this pull request

Sep 25, 2026

Free-threading: PyType_Freeze() can deadlock with concurrent class updates #158194

Closed

Reviewers

vstinner

vstinner left review comments

serhiy-storchaka

serhiy-storchaka approved these changes

picnixz

picnixz left review comments

emmatyping

emmatyping approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

AA-Turner commented May 9, 2025 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

miss-islington-app Bot commented May 10, 2025

Uh oh!

bedevere-app Bot commented May 10, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

AA-Turner commented May 9, 2025 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.