GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-133677: Fix tests when running in non-UTF-8 locale by serhiy-storchaka · Pull Request #133865 · python/cpython

Conversation

serhiy-storchaka commented May 11, 2025 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Issue: Several tests fail when system encoding is latin-1 #133677

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

serhiy-storchaka requested a review from barneygale as a code owner

May 11, 2025 07:07

serhiy-storchaka added the tests Tests in the Lib/test dir label

May 11, 2025

serhiy-storchaka requested review from 1st1, asvetlov and kumaraditya303 as code owners

May 11, 2025 07:07

serhiy-storchaka added the skip news label

May 11, 2025

serhiy-storchaka requested review from savannahostrowski and willingc as code owners

May 11, 2025 07:07

bedevere-app Bot mentioned this pull request

May 11, 2025

Several tests fail when system encoding is latin-1 #133677

Closed

bedevere-app Bot added the awaiting core review label

May 11, 2025


          pythongh-133677: Fix tests when running in non-UTF-8 locale

842076d

serhiy-storchaka force-pushed the tests-non-utf8-locale branch from 48e3a7c to 842076d Compare

May 11, 2025 07:55

This was referenced May 11, 2025

gh-133677 Skip test in test_zipfile if not UTF-8 #133715

Closed

gh-133677: Skip test in test_asyncio if not UTF-8 #133719

Closed

StanFromIreland reviewed

May 11, 2025

View reviewed changes

Comment thread

Lib/test/test_asyncio/test_tools.py


		def test_task_awaits_self(self):
		"""A task directly awaits itself – should raise a cycle."""
		"""A task directly awaits itself - should raise a cycle."""

StanFromIreland May 11, 2025

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all unrelated.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

serhiy-storchaka May 11, 2025

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very related. Error happens when non-ASCII "–" is written to stdout with a non-UTF-8 encoding.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AA-Turner reacted with thumbs up emoji

All reactions

👍 1 reaction

StanFromIreland commented May 11, 2025

Copy link

Copy Markdown

Member

This is also against the wrong branch, main will be unaffected once #133712

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Try to fix test_argparse on Windows.

68d3b24

AA-Turner approved these changes

May 11, 2025

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting core review labels

May 11, 2025

serhiy-storchaka merged commit 14305a8 into python:main

May 12, 2025

bedevere-app Bot removed the awaiting merge label

May 12, 2025

serhiy-storchaka deleted the tests-non-utf8-locale branch

May 12, 2025 16:14

serhiy-storchaka added needs backport to 3.13

only security fixes

needs backport to 3.14 bugs and security fixes labels

May 12, 2025

miss-islington-app Bot commented May 12, 2025

Copy link

Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington-app Bot commented May 12, 2025

Copy link

Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

May 12, 2025


          pythongh-133677: Fix tests when running in non-UTF-8 locale (pythonGH…

7307ff5

…-133865)

(cherry picked from commit 14305a8)

Co-authored-by: Serhiy Storchaka <[email protected]>

miss-islington-app Bot commented May 12, 2025

Copy link

Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 14305a83d381ccdcae814abd9e2c28dda066720b 3.13

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington-app Bot assigned serhiy-storchaka

May 12, 2025

bedevere-app Bot commented May 12, 2025

Copy link

Copy Markdown

GH-133938 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label

May 12, 2025

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request

May 12, 2025


          [3.13] pythongh-133677: Fix tests when running in non-UTF-8 locale (p…

314ba03

…ythonGH-133865)

(cherry picked from commit 14305a8)

Co-authored-by: Serhiy Storchaka <[email protected]>

bedevere-app Bot commented May 12, 2025

Copy link

Copy Markdown

GH-133939 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label

May 12, 2025

serhiy-storchaka removed their assignment

May 12, 2025

serhiy-storchaka added a commit that referenced this pull request

May 12, 2025


          [3.14] gh-133677: Fix tests when running in non-UTF-8 locale (GH-133865…

c11fc4b

…) (GH-133938)

(cherry picked from commit 14305a8)

Co-authored-by: Serhiy Storchaka <[email protected]>

StanFromIreland commented May 12, 2025

Copy link

Copy Markdown

Member

Relevant buildbot run for this PR: https://buildbot.python.org/#/builders/1678/builds/37 (Not linked by gh at the moment)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka added a commit that referenced this pull request

May 12, 2025


          [3.13] gh-133677: Fix tests when running in non-UTF-8 locale (GH-133865…

d9d8e9a

…) (GH-133939)

(cherry picked from commit 14305a8)

Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request

Jul 12, 2025


          pythongh-133677: Fix tests when running in non-UTF-8 locale (pythonGH…

…-133865)

taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request

Aug 4, 2025


          pythongh-133677: Fix tests when running in non-UTF-8 locale (pythonGH…

0ad785c

…-133865)

Reviewers

StanFromIreland

StanFromIreland left review comments

AA-Turner

AA-Turner approved these changes

barneygale

Awaiting requested review from barneygale

barneygale is a code owner

1st1

Awaiting requested review from 1st1

1st1 is a code owner

asvetlov

Awaiting requested review from asvetlov

asvetlov is a code owner

kumaraditya303

Awaiting requested review from kumaraditya303

kumaraditya303 is a code owner

willingc

Awaiting requested review from willingc

willingc is a code owner

savannahostrowski

Awaiting requested review from savannahostrowski

savannahostrowski is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests

Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

serhiy-storchaka commented May 11, 2025 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

StanFromIreland May 11, 2025

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka May 11, 2025

Choose a reason for hiding this comment

Uh oh!

StanFromIreland commented May 11, 2025

Uh oh!

miss-islington-app Bot commented May 12, 2025

Uh oh!

miss-islington-app Bot commented May 12, 2025

Uh oh!

miss-islington-app Bot commented May 12, 2025

Uh oh!

bedevere-app Bot commented May 12, 2025

Uh oh!

bedevere-app Bot commented May 12, 2025

Uh oh!

StanFromIreland commented May 12, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

serhiy-storchaka commented May 11, 2025 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.