GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-133604: remove deprecated `java_ver` function by makridenko · Pull Request #133888 · python/cpython

Conversation

@makridenko

@makridenko makridenko commented May 11, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Remove deprecated platform.java_ver #133604

📚 Documentation preview 📚: https://cpython-previews--133888.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@makridenko
remove deprecated java_ver function and update related documentation
4f0b53e
@python-cla-bot

python-cla-bot Bot commented May 11, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented May 11, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot mentioned this pull request May 11, 2025
Remove deprecated platform.java_ver #133604
Closed
@bedevere-app bedevere-app Bot added the awaiting review label May 11, 2025
makridenko added 2 commits May 11, 2025 12:57
@makridenko
remove deprecated java_ver function from documentation
373fe6a
@makridenko
deprecate platform.java_ver function for removal in Python 3.15
b50dbed
eendebakpt
eendebakpt reviewed May 11, 2025
View reviewed changes
Comment thread Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
eendebakpt
eendebakpt reviewed May 11, 2025
View reviewed changes
Comment thread Doc/whatsnew/3.15.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
makridenko added 3 commits May 11, 2025 13:31
@makridenko
update formatting for deprecated platform.java_ver function section…
cbc4dd4 
… in 3.15 release notes
@makridenko
Merge branch 'main' into fix-issue-133604
51d2061
@makridenko
Merge branch 'main' into fix-issue-133604
4157fa5
StanFromIreland
StanFromIreland reviewed May 11, 2025
View reviewed changes
Comment thread Doc/whatsnew/3.15.rst Outdated
platform
--------

* The deprecated :func:`!platform.java_ver` function.

@StanFromIreland StanFromIreland May 11, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* The deprecated :func:`!platform.java_ver` function.
* Removed the deprecated :func:`!platform.java_ver` function.

To save Benedikt copy-editing it later. (See line 133)

You can also link this pr. (See line 134 as an example)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@makridenko makridenko May 13, 2025

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StanFromIreland thank you! done

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/platform.py Outdated
#
# <see CVS and SVN checkin messages for history>
#
# 1.1.0 - removed deprecated java_ver()

@StanFromIreland StanFromIreland May 11, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not noteworthy enough IMO. These are rarely updated, but it is up to @malemburg in the end.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@malemburg malemburg May 12, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to add to that list anymore. The checkin messages provide enough history.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
StanFromIreland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@malemburg malemburg May 12, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to change # <see CVS and SVN checkin messages for history> to # <see checkin messages for history>

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@makridenko makridenko May 13, 2025

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malemburg thank you! done

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
makridenko added 3 commits May 13, 2025 14:31
@makridenko
update removal notice for deprecated platform.java_ver function in …
2c9d038 
…3.15 release notes
@makridenko
Merge branch 'fix-issue-133604' of https://github.com/makridenko/cpython
0139eb1 
 into fix-issue-133604
@makridenko
Merge branch 'main' into fix-issue-133604
b9f2cf6
@makridenko
makridenko requested review from StanFromIreland and malemburg May 14, 2025 08:29
picnixz
picnixz reviewed May 16, 2025
View reviewed changes
Comment thread Doc/whatsnew/3.15.rst Outdated
Comment on lines +127 to +128
* Removed the deprecated :func:`!platform.java_ver` function.
(Contributed by Alexey Makridenko in :gh:`133888`.)

@picnixz picnixz May 16, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Removed the deprecated :func:`!platform.java_ver` function.
(Contributed by Alexey Makridenko in :gh:`133888`.)
* Removed the :func:`!platform.java_ver` function,
which was deprecated since Python 3.13.
(Contributed by Alexey Makridenko in :gh:`133888`.)

The link should be the issue, not the PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@makridenko makridenko May 16, 2025

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! fixed it

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/platform.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/platform.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/next/Library/2025-05-11-12-56-52.gh-issue-133604.kFxhc8.rst Outdated
@@ -0,0 +1 @@
Remove deprecated function :func:`!platform.java_ver`.

@picnixz picnixz May 16, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Remove deprecated function :func:`!platform.java_ver`.
Remove :func:`!platform.java_ver` which was deprecated since Python 3.13.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@makridenko makridenko May 16, 2025

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! fixed it

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@makridenko
clarify removal notice for deprecated platform.java_ver function in…
e0c4870 
… 3.15 release notes
@makridenko
makridenko requested a review from picnixz May 16, 2025 11:48
@makridenko
add blank line
054efed
picnixz
picnixz reviewed May 16, 2025
View reviewed changes

@picnixz picnixz left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to give you contradictory comments :') I didn't read the previous reviews, my bad!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/whatsnew/3.15.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@makridenko
reformat removal notice
3a709ab
picnixz
picnixz approved these changes May 16, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels May 16, 2025
picnixz
picnixz reviewed May 16, 2025
View reviewed changes
Comment thread Doc/whatsnew/3.15.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@makridenko
lint fix
d50237c
malemburg
malemburg approved these changes May 16, 2025
View reviewed changes

@malemburg malemburg left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I haven't actually run the test suite with these changes, or built the docs.

Note: The PR branch needs to be rebased before it can be merged.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@malemburg

malemburg commented May 16, 2025

Copy link
Copy Markdown
Member

Hmm, apparently, Github changed its mind about the need to rebase.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@malemburg

malemburg commented May 16, 2025

Copy link
Copy Markdown
Member

@StanFromIreland Do want to review again ? Otherwise, I'll merge the PR soon.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@makridenko
Merge branch 'main' into fix-issue-133604
b8c57ee
@malemburg
malemburg merged commit 7a4a6cf into python:main May 16, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label May 16, 2025
@malemburg

malemburg commented May 16, 2025

Copy link
Copy Markdown
Member

Thanks, @makridenko, for your work on this.
makridenko reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland

StanFromIreland commented May 16, 2025

Copy link
Copy Markdown
Member

Apologies I was unavailable.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz picnixz mentioned this pull request Jun 14, 2025
Introduce platform.vm_info (or similar) as a replacement for recently deprecated platform.java_ver. #116504
Open
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@makridenko @Pranjal095
pythongh-133604: remove deprecated java_ver function (python#133888)
cfa5f13
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@makridenko @taegyunkim
pythongh-133604: remove deprecated java_ver function (python#133888)
fe85f53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eendebakpt eendebakpt eendebakpt left review comments
@picnixz picnixz picnixz approved these changes
@malemburg malemburg malemburg approved these changes
@StanFromIreland StanFromIreland Awaiting requested review from StanFromIreland

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@makridenko @malemburg @StanFromIreland @eendebakpt @picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.