GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-30052: Always regenerate cross-references by ncoghlan · Pull Request #1339 · python/cpython

Conversation

@ncoghlan

@ncoghlan ncoghlan commented Apr 28, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The patch for bpo-30052 changed the preferred link target
for :func:bytes and :funcbytearray references to be the
respective type definitions rather than the corresponding
builtin function entries.

This patch changes the daily documentation builds to disable
the output caching in Sphinx, in order to ensure that
cross-reference changes like this one are reliably picked
up and applied automatically after merging.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ncoghlan
ncoghlan requested review from berkerpeksag and birkenfeld April 28, 2017 09:30
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 28, 2017
@mention-bot

mention-bot commented Apr 28, 2017

Copy link
Copy Markdown

@ncoghlan, thanks for your PR! By analyzing the history of the files in this pull request, we identified @birkenfeld, @benjaminp and @tiran to be potential reviewers.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ncoghlan
bpo-30052: Always regenerate cross-references
3766314 
The patch for bpo-30052 changed the preferred link target
for :func:`bytes` and :func`bytearray` references to be the
respective type definitions rather than the corresponding
builtin function entries.

This patch changes the daily documentation builds to disable
the output caching in Sphinx, in order to ensure that
cross-reference changes like this one are reliably picked
up and applied automatically after merging.
@ncoghlan
ncoghlan force-pushed the bpo-30052-regenerate-cross-references branch from e9ef89c to 3766314 Compare April 28, 2017 09:30
@ncoghlan ncoghlan added the needs backport to 3.6 label Apr 28, 2017
berkerpeksag
berkerpeksag approved these changes Apr 28, 2017
View reviewed changes

@berkerpeksag berkerpeksag left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This probably will fix python/docsbuild-scripts#10 too.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Mariatta
Mariatta reviewed Apr 30, 2017
View reviewed changes
Comment thread Misc/NEWS Outdated
Documentation
-------------

- Issue #30052: the link targets for ``:func:\`bytes\``` and

@Mariatta Mariatta Apr 30, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks travis build.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@ncoghlan ncoghlan May 1, 2017

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I can't work out how to get make suspicious to be OK with the escaped markup, so I've asked python-dev for advice: https://mail.python.org/pipermail/python-dev/2017-May/147820.html

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ncoghlan added 2 commits May 1, 2017 17:20
@ncoghlan
Don't attempt to escape markup in NEWS
f0b3c0b
@ncoghlan
Merge remote-tracking branch 'origin/master' into bpo-30052-regenerat…
8054773 
…e-cross-references
@brettcannon brettcannon added the type-bug An unexpected behavior, bug, or error label May 1, 2017
Mariatta
Mariatta approved these changes May 2, 2017
View reviewed changes
@ncoghlan
ncoghlan merged commit 7a82f9c into python:master Jun 2, 2017
ncoghlan added a commit to ncoghlan/cpython that referenced this pull request Jun 2, 2017
@ncoghlan
bpo-30052: Always regenerate cross-references (python#1339)
5492a12 
* bpo-30052: Always regenerate cross-references

The patch for bpo-30052 changed the preferred link target
for :func:`bytes` and :func`bytearray` references to be the
respective type definitions rather than the corresponding
builtin function entries.

This patch changes the daily documentation builds to disable
the output caching in Sphinx, in order to ensure that
cross-reference changes like this one are reliably picked
up and applied automatically after merging.
(cherry picked from commit 7a82f9c)
@Mariatta Mariatta removed the needs backport to 3.6 label Jun 6, 2017
Mariatta pushed a commit that referenced this pull request Jun 6, 2017
@ncoghlan @Mariatta
bpo-30052: Always regenerate cross-references (GH-1339) (GH-1921)
798cfb2 
The patch for bpo-30052 changed the preferred link target
for :func:`bytes` and :func`bytearray` references to be the
respective type definitions rather than the corresponding
builtin function entries.

This patch changes the daily documentation builds to disable
the output caching in Sphinx, in order to ensure that
cross-reference changes like this one are reliably picked
up and applied automatically after merging.
(cherry picked from commit 7a82f9c)
@ncoghlan
ncoghlan deleted the bpo-30052-regenerate-cross-references branch March 30, 2018 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes
@Mariatta Mariatta Mariatta approved these changes
@birkenfeld birkenfeld Awaiting requested review from birkenfeld

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@ncoghlan @mention-bot @berkerpeksag @Mariatta @brettcannon @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.