GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-132983: Fix zstd compiler warning about unused function mt_continue_should_break() by erlend-aasland · Pull Request #133947 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented May 12, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fixes the following compiler warning:

./Modules/_zstd/compressor.c:490:1: warning: unused function 'mt_continue_should_break' [-Wunused-function]
  490 | mt_continue_should_break(ZSTD_inBuffer *in, ZSTD_outBuffer *out)
      | ^~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
  • Issue: Implement PEP 784 - Adding Zstandard to the Python standard library #132983

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythongh-132983: Fix zstd compiler warning about unused function mt_c…
d58a633 
…ontinue_should_break()
@erlend-aasland erlend-aasland added the skip news label May 12, 2025
@erlend-aasland
erlend-aasland requested a review from emmatyping May 12, 2025 18:36
@bedevere-app bedevere-app Bot mentioned this pull request May 12, 2025
Implement PEP 784 - Adding Zstandard to the Python standard library #132983
Closed
13 tasks done
@bedevere-app bedevere-app Bot added the awaiting core review label May 12, 2025
@erlend-aasland

erlend-aasland commented May 12, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

AFAICS, mt_continue_should_break is only used in an assert, so we can safely only define it if we're debugging.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland mentioned this pull request May 12, 2025
Unreachable code warnings while building latest main at 48c70b8 #128086
Closed
emmatyping
emmatyping approved these changes May 12, 2025
View reviewed changes
AA-Turner
AA-Turner approved these changes May 12, 2025
View reviewed changes

@AA-Turner AA-Turner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't see this compiler warning locally (do you need different flags for it?).

A

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 12, 2025
@AA-Turner AA-Turner added the needs backport to 3.14 bugs and security fixes label May 12, 2025
@AA-Turner
AA-Turner merged commit 121ed71 into python:main May 12, 2025
@miss-islington-app

This comment was marked as outdated.

Sign in to view
@bedevere-app bedevere-app Bot removed the awaiting merge label May 12, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 12, 2025
@erlend-aasland @miss-islington
pythongh-132983: Fix compiler warning about unused function ``mt_cont…
f2c2318 
…inue_should_break()`` (pythonGH-133947)

(cherry picked from commit 121ed71)

Co-authored-by: Erlend E. Aasland <[email protected]>
@bedevere-app

bedevere-app Bot commented May 12, 2025

Copy link
Copy Markdown

GH-133950 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 12, 2025
@erlend-aasland
erlend-aasland deleted the zstd-warning branch May 12, 2025 19:24
AA-Turner pushed a commit that referenced this pull request May 12, 2025
@miss-islington @erlend-aasland
[3.14] gh-132983: Fix compiler warning about unused function ``mt_con…
c1aa5f8 
…tinue_should_break()`` (GH-133947) (#133950)

gh-132983: Fix compiler warning about unused function ``mt_continue_should_break()`` (GH-133947)
(cherry picked from commit 121ed71)

Co-authored-by: Erlend E. Aasland <[email protected]>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@erlend-aasland @Pranjal095
pythongh-132983: Fix compiler warning about unused function ``mt_cont…
d53338e 
…inue_should_break()`` (python#133947)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@erlend-aasland @taegyunkim
pythongh-132983: Fix compiler warning about unused function ``mt_cont…
fef033c 
…inue_should_break()`` (python#133947)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-Turner AA-Turner AA-Turner approved these changes
@emmatyping emmatyping emmatyping approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@erlend-aasland @AA-Turner @emmatyping
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.