GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-115119: Removed bundled copy of the libmpdec by skirpichev · Pull Request #133964 · python/cpython

Conversation

@skirpichev

@skirpichev skirpichev commented May 13, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Unvendor libmpdec sources #115119

📚 Documentation preview 📚: https://cpython-previews--133964.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@skirpichev
pythongh-115119: Removed bundled copy of the libmpdec
c8b8a57
@bedevere-app bedevere-app Bot mentioned this pull request May 13, 2025
Unvendor libmpdec sources #115119
Closed
15 tasks done
skirpichev added 2 commits May 13, 2025 13:30
@skirpichev
+ configure
43c8721
@skirpichev
+1
9d6c9b5
@skirpichev
skirpichev force-pushed the remove-bundled-mpdecimal/115119 branch from 7cba56a to 9d6c9b5 Compare May 13, 2025 15:37
AA-Turner
AA-Turner reviewed May 13, 2025
View reviewed changes

@AA-Turner AA-Turner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick comments, haven't looked at build system changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/using/configure.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.15.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/sbom.spdx.json Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/Setup.stdlib.in Resolved

Uh oh!

There was an error while loading. Please reload this page.
skirpichev and others added 2 commits May 13, 2025 19:21
@skirpichev @AA-Turner
Apply suggestions from code review
5de2aa2 
Co-authored-by: Adam Turner <[email protected]>
@skirpichev
+ configure
dfd9f40
zware
zware previously requested changes May 13, 2025
View reviewed changes
Comment thread PCbuild/_decimal.vcxproj.filters Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

This comment was marked as resolved.

Sign in to view
@bedevere-app bedevere-app Bot added the awaiting changes label May 13, 2025
AA-Turner and others added 6 commits May 13, 2025 19:52
@AA-Turner
autoconf
769a36a
@AA-Turner
revert
60f7ae2
@AA-Turner
makesetup
b9af863
@skirpichev
+ lint and macos
81c7020
@AA-Turner
Windows: SBOM
3bf12e8
@AA-Turner
lint
4555447
@AA-Turner

This comment was marked as resolved.

Sign in to view
skirpichev added 2 commits May 14, 2025 06:20
@skirpichev
fix docs
2fca0e5
@skirpichev
XXX disable _decimal if no libmpdec is available
800dd01
@skirpichev

This comment was marked as resolved.

Sign in to view
@bedevere-app bedevere-app Bot added awaiting change review and removed awaiting changes labels May 14, 2025
@bedevere-app

This comment was marked as resolved.

Sign in to view
@bedevere-app
bedevere-app Bot requested a review from zware May 14, 2025 03:41
@skirpichev
+1
be3d413
@skirpichev

This comment was marked as resolved.

Sign in to view
skirpichev added 2 commits May 14, 2025 07:51
@skirpichev
fix json
bd03679
@skirpichev
reorder
2ba6b8b
@skirpichev
skirpichev force-pushed the remove-bundled-mpdecimal/115119 branch from 0a33f9f to 2ba6b8b Compare May 14, 2025 05:49
skirpichev added 2 commits May 9, 2026 06:48
@skirpichev
address review: revert unrelated change
081d1e0
@skirpichev
address review: cleanup configure.ac
97767d6
@skirpichev
skirpichev requested a review from zware May 9, 2026 05:59
sethmlarson
sethmlarson approved these changes May 11, 2026
View reviewed changes

@sethmlarson sethmlarson left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the changes to sbom.spdx.json and generate_sbom.py and those changes LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels May 11, 2026
@skirpichev
Merge branch 'main' into remove-bundled-mpdecimal/115119
57bd0b0
zware
zware reviewed May 11, 2026
View reviewed changes

@zware zware left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite close, I think, just a few more cleanups.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/license.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/tools/removed-ids.txt Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.16.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_decimal/README.txt Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_decimal/README.txt Resolved

Uh oh!

There was an error while loading. Please reload this page.
skirpichev added 5 commits May 12, 2026 07:06
@skirpichev
Merge branch 'master' into remove-bundled-mpdecimal/115119
fa0d506
@skirpichev
address review: move news
0cab465
@skirpichev
address review: trying to reword license.rst
f4a1b18
@skirpichev
address review: cleanup Modules/_decimal/README.txt
11867cd
@skirpichev
address review: set module missing, if have_mpdec==no
0e3afd7
@skirpichev
skirpichev requested a review from zware May 12, 2026 04:07
zware
zware reviewed May 12, 2026
View reviewed changes
Comment thread Doc/whatsnew/3.16.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/license.rst Outdated
Comment on lines 962 to 964
Previously, the :mod:`!_decimal` C extension underlying the :mod:`decimal` module
was built using an included copy of the libmpdec
library unless the build is configured ``--with-system-libmpdec``::

@zware zware May 12, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't hurt to fix the libffi section as well. Suggested wording here, though:

Suggested change
Previously, the :mod:`!_decimal` C extension underlying the :mod:`decimal` module
was built using an included copy of the libmpdec
library unless the build is configured ``--with-system-libmpdec``::
The :mod:`!_decimal` C extension underlying the :mod:`decimal` module
is linked to the libmpdec C library::

On the other hand, we could just leave this file alone for now and get someone more knowledgeable about such things to tell us what we should do in a separate issue :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@skirpichev skirpichev May 12, 2026

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then lets keep this intact.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
zware reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread configure.ac
# Disable forced inlining in debug builds, see GH-94847
AS_VAR_IF(
[with_pydebug], [yes],
[AS_VAR_APPEND([LIBMPDEC_CFLAGS], [" -DTEST_COVERAGE"])])

@zware zware May 12, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only relevant for building libmpdec itself, isn't it?

There is a usage of TEST_COVERAGE in Modules/_decimal/_decimal.c, but I don't see anything ever defining it for that module.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@skirpichev skirpichev May 12, 2026

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a usage of TEST_COVERAGE in Modules/_decimal/_decimal.c, but I don't see anything ever defining it for that module.

It's defined there, no?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@zware zware May 12, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, sorry, my understanding of how LIBMPDEC_{CFLAGS,LDFLAGS} work was incorrect; this is fine.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@skirpichev skirpichev May 13, 2026

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this define used only in one place, we could replace it with Py_DEBUG in the code.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_decimal/README.txt Resolved

Uh oh!

There was an error while loading. Please reload this page.
skirpichev and others added 3 commits May 12, 2026 23:06
@skirpichev @zware
Apply suggestions from code review
0dd4a29 
Co-authored-by: Zachary Ware <[email protected]>
@skirpichev
address review: configure.ac cleanup
59a7986
@skirpichev
Merge branch 'master' into remove-bundled-mpdecimal/115119
c1e262a
@skirpichev
skirpichev requested a review from zware May 12, 2026 20:18
zware
zware reviewed May 12, 2026
View reviewed changes
Comment thread Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/license.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@zware
Apply suggestions from code review
b4cc60d 
Co-authored-by: Zachary Ware <[email protected]>
@zware
zware enabled auto-merge (squash) May 12, 2026 21:08
zware
zware approved these changes May 12, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 12, 2026
@zware
zware merged commit 9eb3b14 into python:main May 12, 2026
69 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label May 12, 2026
@skirpichev
skirpichev deleted the remove-bundled-mpdecimal/115119 branch May 13, 2026 01:42
@hugovk hugovk mentioned this pull request Sep 17, 2026
gh-115119: Fix licence page after removing bundled copy of libmpdec #157686
Merged
@freakboy3742 freakboy3742 mentioned this pull request Oct 12, 2026
gh-115119: Remove deprecated --with-system-mpdec option from iOS build. #159215
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily ned-deily left review comments
@zware zware zware approved these changes
@sethmlarson sethmlarson sethmlarson approved these changes
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner
@StanFromIreland StanFromIreland Awaiting requested review from StanFromIreland StanFromIreland is a code owner
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@emmatyping emmatyping Awaiting requested review from emmatyping emmatyping is a code owner
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@skirpichev @AA-Turner @ned-deily @zware @sethmlarson @StanFromIreland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.