GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-115119: Fix licence page after removing bundled copy of libmpdec by hugovk · Pull Request #157686 · python/cpython

Conversation

hugovk commented Sep 17, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Follow on from PR #133964.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Fix licence page after removing bundled copy of libmpdec

3fcc72e

bedevere-app Bot mentioned this pull request

Sep 17, 2026

Unvendor libmpdec sources #115119

Closed

15 tasks done

bedevere-app Bot added docs

Documentation in the Doc dir

skip news labels

Sep 17, 2026

github-project-automation Bot added this to Docs PRs

Sep 17, 2026

bedevere-app Bot added the awaiting core review label

Sep 17, 2026

github-project-automation Bot moved this to Todo in Docs PRs

Sep 17, 2026

hugovk mentioned this pull request

Sep 17, 2026

Update libmpdec-related instructions python/devguide#1907

Merged

read-the-docs-community Bot commented Sep 17, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #34631884 | 📁 Comparing 6b25835 against main (8759666)

🔍 Preview build

5 files changed · ± 5 modified

± Modified

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

StanFromIreland reviewed

Sep 17, 2026

View reviewed changes

Comment thread

Doc/license.rst

		library unless the build is configured ``--with-system-libmpdec``::
		uses the libmpdec library if made available by the operating system.
		Additionally, the Windows and macOS installers for Python include a copy
		of the libmpdec library, so we include a copy of the libmpdec license here::

StanFromIreland Sep 17, 2026

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe re-word this a little, this is quite nitty, so feel free to reject:

The :mod:`!_decimal` accelerator module for the :mod:`decimal` module
is linked against the `libmpdec <https://www.bytereef.org/mpdecimal/>`__
library if it is available on the system. The Windows and macOS installers
for Python bundle a copy of libmpdec, so its license is included here::

To clarify that just because decimal is present, it does not mean _decimal is. And, add a link to the library's website, since I presume that may be useful for people unfamiliar. Also coupled with a few little tweaks.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

hugovk Sep 18, 2026

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, not sure we need this detail here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

StanFromIreland Sep 18, 2026

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally don't find it too extensive, but I'll leave it up to you.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

hugovk Sep 18, 2026

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can always change it later :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Doc/license.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Update years to match https://github.com/python/cpython-source-deps/b…

6b25835

…lob/mpdecimal/COPYRIGHT.txt

Co-authored-by: Stan Ulbrych <[email protected]>

StanFromIreland approved these changes

Sep 18, 2026

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting core review labels

Sep 18, 2026

hugovk merged commit e66424a into python:main

Sep 18, 2026

34 checks passed

Uh oh!

There was an error while loading. Please reload this page.

hugovk deleted the 3.16-rm-mpdecimal branch

September 18, 2026 10:05

bedevere-app Bot removed the awaiting merge label

Sep 18, 2026

github-project-automation Bot moved this from Todo to Done in Docs PRs

Sep 18, 2026

Reviewers

StanFromIreland

StanFromIreland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs

Documentation in the Doc dir

skip news

Projects

Docs PRs

Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

hugovk commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

read-the-docs-community Bot commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Documentation build overview

Uh oh!

StanFromIreland Sep 17, 2026

Choose a reason for hiding this comment

Uh oh!

hugovk Sep 18, 2026

Choose a reason for hiding this comment

Uh oh!

StanFromIreland Sep 18, 2026

Choose a reason for hiding this comment

Uh oh!

hugovk Sep 18, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hugovk commented Sep 17, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

read-the-docs-community Bot commented Sep 17, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.