GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-106213: Shorten Emscripten wasm-gc trampoline by a little by hoodmane · Pull Request #133984 · python/cpython

Conversation

@hoodmane

@hoodmane hoodmane commented May 13, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

I found out about the if instruction which lets us have slightly shorter code here.

  • Issue: Emscripten JS trampolines do not interact well with wasm stack switching #106213

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot mentioned this pull request May 13, 2025
Emscripten trampolines not quite right since #106219 #121700
Closed
@bedevere-app bedevere-app Bot added the awaiting review label May 13, 2025
@hoodmane
pythongh-106213 Shorten Emscripten trampolines by a little
de6ffa6 
I found out about the `if` instruction which lets us have slightly
shorter code here.
@hoodmane
hoodmane force-pushed the shorter-emscripten-wasm-gc-trampoline branch from 5680660 to de6ffa6 Compare May 13, 2025 20:38
@hoodmane hoodmane changed the title gh-121700 Shorten Emscripten trampolines by a little gh-106213 Shorten Emscripten wasm-gc trampolines by a little May 13, 2025
@bedevere-app bedevere-app Bot mentioned this pull request May 13, 2025
Emscripten JS trampolines do not interact well with wasm stack switching #106213
Closed
@hoodmane hoodmane changed the title gh-106213 Shorten Emscripten wasm-gc trampolines by a little gh-106213 Shorten Emscripten wasm-gc trampoline by a little May 13, 2025
@hoodmane hoodmane added the skip news label May 13, 2025
@freakboy3742 freakboy3742 added the needs backport to 3.14 bugs and security fixes label May 20, 2025
@freakboy3742 freakboy3742 changed the title gh-106213 Shorten Emscripten wasm-gc trampoline by a little gh-106213: Shorten Emscripten wasm-gc trampoline by a little May 20, 2025
freakboy3742
freakboy3742 approved these changes May 20, 2025
View reviewed changes

@freakboy3742 freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels May 20, 2025
@freakboy3742
freakboy3742 merged commit 3b7888b into python:main May 20, 2025
@miss-islington-app

miss-islington-app Bot commented May 20, 2025

Copy link
Copy Markdown

Thanks @hoodmane for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label May 20, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2025
@hoodmane @miss-islington
pythongh-106213: Shorten Emscripten wasm-gc trampoline by a little (p…
f4a6798 
…ythonGH-133984)

Using the if instruction results in slightly shorter trampoline code.
(cherry picked from commit 3b7888b)

Co-authored-by: Hood Chatham <[email protected]>
@bedevere-app

bedevere-app Bot commented May 20, 2025

Copy link
Copy Markdown

GH-134376 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 20, 2025
freakboy3742 pushed a commit that referenced this pull request May 20, 2025
@miss-islington @hoodmane
[3.14] gh-106213: Shorten Emscripten wasm-gc trampoline by a little (G…
2d90cc8 
…H-133984) (#134376)

Using the if instruction results in slightly shorter trampoline code.
(cherry picked from commit 3b7888b)

Co-authored-by: Hood Chatham <[email protected]>
lkollar pushed a commit to lkollar/cpython that referenced this pull request May 26, 2025
@hoodmane @lkollar
pythongh-106213: Shorten Emscripten wasm-gc trampoline by a little (p…
b42ee0a 
…ython#133984)

Using the if instruction results in slightly shorter trampoline code.
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@hoodmane @Pranjal095
pythongh-106213: Shorten Emscripten wasm-gc trampoline by a little (p…
3537a59 
…ython#133984)

Using the if instruction results in slightly shorter trampoline code.
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@hoodmane @taegyunkim
pythongh-106213: Shorten Emscripten wasm-gc trampoline by a little (p…
273e67c 
…ython#133984)

Using the if instruction results in slightly shorter trampoline code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hoodmane @freakboy3742
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.