GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Docs: Fix indent in `controlflow.rst` by Yzi-Li · Pull Request #134008 · python/cpython

Conversation

@Yzi-Li

@Yzi-Li Yzi-Li commented May 14, 2025 •
edited by ZeroIntensity
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

I really ran this code, there shouldn't be indentation here.

Before

Do nothing, but document it.

    No, really, it doesn't do anything.

Should be

Do nothing, but document it.

No, really, it doesn't do anything.

📚 Documentation preview 📚: https://cpython-previews--134008.org.readthedocs.build/en/134008/tutorial/controlflow.html#documentation-strings

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Yzi-Li
Fix indent in controlflow.rst
8f7130d
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels May 14, 2025
@github-project-automation github-project-automation Bot added this to Docs PRs May 14, 2025
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs May 14, 2025
@ZeroIntensity ZeroIntensity added skip issue needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels May 14, 2025
ZeroIntensity
ZeroIntensity approved these changes May 14, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels May 14, 2025
kumaraditya303
kumaraditya303 approved these changes May 18, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 18, 2025
@kumaraditya303
kumaraditya303 merged commit 4ce9187 into python:main May 18, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label May 18, 2025
@miss-islington-app

miss-islington-app Bot commented May 18, 2025

Copy link
Copy Markdown

Thanks @Yzi-Li for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs May 18, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 18, 2025
@Yzi-Li @miss-islington
fix indent in controlflow.rst docs (pythonGH-134008)
684d5cd 
(cherry picked from commit 4ce9187)

Co-authored-by: Yongzi Li <[email protected]>
@bedevere-app

bedevere-app Bot commented May 18, 2025

Copy link
Copy Markdown

GH-134184 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 18, 2025
@Yzi-Li @miss-islington
fix indent in controlflow.rst docs (pythonGH-134008)
4d9d3bd 
(cherry picked from commit 4ce9187)

Co-authored-by: Yongzi Li <[email protected]>
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 18, 2025
@bedevere-app

bedevere-app Bot commented May 18, 2025

Copy link
Copy Markdown

GH-134185 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 18, 2025
kumaraditya303 pushed a commit that referenced this pull request May 18, 2025
@miss-islington @Yzi-Li
[3.13] fix indent in controlflow.rst docs (GH-134008) (#134185)
9c29769 
fix indent in `controlflow.rst` docs (GH-134008)
(cherry picked from commit 4ce9187)

Co-authored-by: Yongzi Li <[email protected]>
kumaraditya303 pushed a commit that referenced this pull request May 18, 2025
@miss-islington @Yzi-Li
[3.14] fix indent in controlflow.rst docs (GH-134008) (#134184)
11650c3 
fix indent in `controlflow.rst` docs (GH-134008)
(cherry picked from commit 4ce9187)

Co-authored-by: Yongzi Li <[email protected]>
@Yzi-Li
Yzi-Li deleted the fix-indent-in-controlflow branch May 23, 2025 13:45
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@Yzi-Li @Pranjal095
fix indent in controlflow.rst docs (python#134008)
411a5f0
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@Yzi-Li @taegyunkim
fix indent in controlflow.rst docs (python#134008)
d63a515
@decorator-factory decorator-factory mentioned this pull request Dec 8, 2025
gh-142411: Change documentation to reflect the new docstring adjustments in 3.13 #142413
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes
@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Yzi-Li @ZeroIntensity @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.