GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-133999: Fix `except` parsing regression in 3.14 by sobolevn · Pull Request #134035 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented May 15, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Basically, we only need to parse as a=expression second-pass case, when block can be parsed further. Otherwise, it is a problem with block, not except

  • Issue: Incorrect syntax error #133999

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-133999: Fix except parsing regression in 3.14
f5eb02c
@sobolevn
sobolevn requested review from lysnikolaou and pablogsal as code owners May 15, 2025 08:40
@bedevere-app bedevere-app Bot mentioned this pull request May 15, 2025
Incorrect syntax error #133999
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label May 15, 2025
pablogsal
pablogsal approved these changes May 15, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 15, 2025
@sobolevn
sobolevn merged commit 84914ad into python:main May 17, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label May 17, 2025
@sobolevn

sobolevn commented May 17, 2025

Copy link
Copy Markdown
Member Author

Thanks, @pablogsal
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou encukou added the needs backport to 3.14 bugs and security fixes label May 19, 2025
@miss-islington-app

miss-islington-app Bot commented May 19, 2025

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2025
@sobolevn @miss-islington
pythongh-133999: Fix except parsing regression in 3.14 (pythonGH-13…
0ccff19 
…4035)

(cherry picked from commit 84914ad)

Co-authored-by: sobolevn <[email protected]>
@bedevere-app

bedevere-app Bot commented May 19, 2025

Copy link
Copy Markdown

GH-134206 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 19, 2025
sobolevn added a commit that referenced this pull request May 19, 2025
@miss-islington @sobolevn
[3.14] gh-133999: Fix except parsing regression in 3.14 (GH-134035) (…
d9c08c5 
…#134206)

gh-133999: Fix `except` parsing regression in 3.14 (GH-134035)
(cherry picked from commit 84914ad)

Co-authored-by: sobolevn <[email protected]>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@sobolevn @Pranjal095
pythongh-133999: Fix except parsing regression in 3.14 (python#134035)
b00cf25
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@sobolevn @taegyunkim
pythongh-133999: Fix except parsing regression in 3.14 (python#134035)
709261d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sobolevn @pablogsal @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.