GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-133890: Handle UnicodeEncodeError in tarfile by serhiy-storchaka · Pull Request #134147 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented May 17, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

UnicodeEncodeError is now handled the same way as OSError during TarFile member extraction.

  • Issue: TarFile filters fail in non-UTF-8 locales #133890

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
pythongh-133890: Handle UnicodeEncodeError in tarfile
6772f2d 
UnicodeEncodeError is now handled the same way as OSError during
TarFile member extraction.
@serhiy-storchaka
serhiy-storchaka requested a review from ethanfurman as a code owner May 17, 2025 16:54
@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels May 17, 2025
@bedevere-app bedevere-app Bot added the awaiting core review label May 17, 2025
@bedevere-app bedevere-app Bot mentioned this pull request May 17, 2025
TarFile filters fail in non-UTF-8 locales #133890
Closed
@serhiy-storchaka
Fix tests on Windows.
de4fe01
@serhiy-storchaka serhiy-storchaka mentioned this pull request May 18, 2025
os.path.realpath raises a ValueError when path contains a null byte #117596
Closed
@serhiy-storchaka
Extract realpath() tests to a separate PR.
730ff5b
@serhiy-storchaka
serhiy-storchaka merged commit 9983c7d into python:main May 18, 2025
@miss-islington-app

miss-islington-app Bot commented May 18, 2025

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label May 18, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 18, 2025
@serhiy-storchaka @miss-islington
pythongh-133890: Handle UnicodeEncodeError in tarfile (pythonGH-134147)
f2184e3 
UnicodeEncodeError is now handled the same way as OSError during
TarFile member extraction.
(cherry picked from commit 9983c7d)

Co-authored-by: Serhiy Storchaka <[email protected]>
@miss-islington-app

miss-islington-app Bot commented May 18, 2025

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 9983c7d4416cac8deb2fded1ec9c7daf786c3a02 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned serhiy-storchaka May 18, 2025
@serhiy-storchaka
serhiy-storchaka deleted the tarfile-filter-unencodable branch May 18, 2025 19:21
@bedevere-app

bedevere-app Bot commented May 18, 2025

Copy link
Copy Markdown

GH-134195 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 18, 2025
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request May 18, 2025
@serhiy-storchaka
[3.13] pythongh-133890: Handle UnicodeEncodeError in tarfile (pythonG…
5d07c55 
…H-134147)

UnicodeEncodeError is now handled the same way as OSError during
TarFile member extraction.
(cherry picked from commit 9983c7d)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app

bedevere-app Bot commented May 18, 2025

Copy link
Copy Markdown

GH-134196 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 18, 2025
serhiy-storchaka added a commit that referenced this pull request May 19, 2025
@serhiy-storchaka
[3.13] gh-133890: Handle UnicodeEncodeError in tarfile (GH-134147) (G…
06a8c06 
…H-134196)

UnicodeEncodeError is now handled the same way as OSError during
TarFile member extraction.
(cherry picked from commit 9983c7d)
serhiy-storchaka added a commit that referenced this pull request May 20, 2025
@miss-islington @serhiy-storchaka
[3.14] gh-133890: Handle UnicodeEncodeError in tarfile (GH-134147) (G…
c23bdc2 
…H-134195)

UnicodeEncodeError is now handled the same way as OSError during
TarFile member extraction.
(cherry picked from commit 9983c7d)

Co-authored-by: Serhiy Storchaka <[email protected]>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@serhiy-storchaka @Pranjal095
pythongh-133890: Handle UnicodeEncodeError in tarfile (pythonGH-134147)
3d18b76 
UnicodeEncodeError is now handled the same way as OSError during
TarFile member extraction.
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@serhiy-storchaka @taegyunkim
pythongh-133890: Handle UnicodeEncodeError in tarfile (pythonGH-134147)
a425077 
UnicodeEncodeError is now handled the same way as OSError during
TarFile member extraction.
mcepl pushed a commit to openSUSE-Python/cpython that referenced this pull request Sep 19, 2025
@serhiy-storchaka @mcepl
pythongh-133890: Handle UnicodeEncodeError in tarfile (pythonGH-134147)
8f56b7d 
UnicodeEncodeError is now handled the same way as OSError during
TarFile member extraction.
(cherry picked from commit 9983c7d)

Co-authored-by: Serhiy Storchaka <[email protected]>
@serhiy-storchaka serhiy-storchaka removed their assignment Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.