GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-128307: Update docs for asyncio.create_task, TaskGroup.create_task, asyncio.create_task by graingert · Pull Request #134202 · python/cpython

Conversation

@graingert

@graingert graingert commented May 19, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: add eager_start parameter to loop.create_task #128307

📚 Documentation preview 📚: https://cpython-previews--134202.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@graingert
pythongh-128307: update docs to TaskGroup.create_task and asyncio.cre…
fc37061 
…ate_task
@bedevere-app bedevere-app Bot mentioned this pull request May 19, 2025
add eager_start parameter to loop.create_task #128307
Closed
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news labels May 19, 2025
@github-project-automation github-project-automation Bot added this to Docs PRs May 19, 2025
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs May 19, 2025
graingert
graingert commented May 19, 2025
View reviewed changes
Comment thread Doc/library/asyncio-eventloop.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
graingert
graingert commented May 19, 2025
View reviewed changes
Comment thread Doc/library/asyncio-eventloop.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
graingert added 2 commits May 19, 2025 09:15
@graingert
Update Doc/library/asyncio-eventloop.rst
18b6bb5
@graingert
Update Doc/library/asyncio-eventloop.rst
10ac910
graingert
graingert commented May 19, 2025
View reviewed changes
Comment thread Doc/library/asyncio-task.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@graingert
Update Doc/library/asyncio-task.rst
7d74976
gvanrossum
gvanrossum reviewed May 20, 2025
View reviewed changes
Comment thread Doc/library/asyncio-eventloop.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum gvanrossum mentioned this pull request May 20, 2025
gh-128307: Update what's new in 3.13 and 3.14 with create_task changes #134304
Merged
graingert added 2 commits May 20, 2025 07:45
@graingert
pre-commit
7127483
@graingert
Merge branch 'main' into doc-new-asyncio-create-task-kwargs
a339251
@graingert
graingert marked this pull request as ready for review May 20, 2025 06:54
@graingert
graingert requested review from 1st1, asvetlov, kumaraditya303 and willingc as code owners May 20, 2025 06:54
@bedevere-app bedevere-app Bot added the awaiting review label May 20, 2025
gvanrossum
gvanrossum reviewed May 20, 2025
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except I'm uneasy with how name, context and eager_task arguments are presented.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/library/asyncio-eventloop.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum

gvanrossum commented May 20, 2025

Copy link
Copy Markdown
Member

You're also going to backport these to 3.13 right? (But describing how 3.13.4 works -- you can't change 3.13.3 by definition).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@graingert

graingert commented May 20, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

You're also going to backport these to 3.13 right? (But describing how 3.13.4 works -- you can't change 3.13.3 by definition).

I thought we were happy with the docs on 3.13 now? So this won't need a backport
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum

gvanrossum commented May 20, 2025

Copy link
Copy Markdown
Member

I thought we were happy with the docs on 3.13 now? So this won't need a backport

Agreed, not to 3.13. But this should be marked as backport to 3.14 right?

What do you think about my comment on the signature description?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum gvanrossum added the needs backport to 3.14 bugs and security fixes label May 20, 2025
gvanrossum
gvanrossum approved these changes May 22, 2025
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG then! I will merge and ensure a backport to 3.14 happens.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels May 22, 2025
@gvanrossum gvanrossum changed the title gh-128307: update docs to TaskGroup.create_task and asyncio.create_task gh-128307: Update docs for asyncio.create_task, TaskGroup.create_task, asyncio.create_task May 22, 2025
@gvanrossum
gvanrossum merged commit a3d0306 into python:main May 22, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label May 22, 2025
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs May 22, 2025
@miss-islington-app

miss-islington-app Bot commented May 22, 2025

Copy link
Copy Markdown

Thanks @graingert for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 22, 2025
@graingert @miss-islington
pythongh-128307: Update docs for asyncio.create_task, TaskGroup.creat…
cd5c579 
…e_task, asyncio.create_task (pythonGH-134202)

(cherry picked from commit a3d0306)

Co-authored-by: Thomas Grainger <[email protected]>
@bedevere-app

bedevere-app Bot commented May 22, 2025

Copy link
Copy Markdown

GH-134553 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 22, 2025
kumaraditya303 pushed a commit that referenced this pull request May 23, 2025
@miss-islington @graingert
[3.14] gh-128307: Update docs for asyncio.create_task, TaskGroup.crea…
1cdbb33 
…te_task, asyncio.create_task (GH-134202) (#134553)

gh-128307: Update docs for asyncio.create_task, TaskGroup.create_task, asyncio.create_task (GH-134202)
(cherry picked from commit a3d0306)

Co-authored-by: Thomas Grainger <[email protected]>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@graingert @Pranjal095
pythongh-128307: Update docs for asyncio.create_task, TaskGroup.creat…
2cfbdab 
…e_task, asyncio.create_task (python#134202)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@graingert @taegyunkim
pythongh-128307: Update docs for asyncio.create_task, TaskGroup.creat…
c2dab71 
…e_task, asyncio.create_task (python#134202)
gostak-dd pushed a commit to gostak-dd/cpython that referenced this pull request Jun 2, 2026
@graingert @gostak-dd
pythongh-128307: Update docs for asyncio.create_task, TaskGroup.creat…
e7f23d0 
…e_task, asyncio.create_task (python#134202)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@graingert @gvanrossum @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.