GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-133260: Remove claim that PyUnicode_InternFromString immortalizes by encukou · Pull Request #134213 · python/cpython

Conversation

@encukou

@encukou encukou commented May 19, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: PyUnicode_InternFromString does not immortalize the string as the document claims #133260

📚 Documentation preview 📚: https://cpython-previews--134213.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou
pythongh-133260: Remove claim that PyUnicode_InternFromString immorta…
f99e8d1 
…lizes
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news labels May 19, 2025
@bedevere-app bedevere-app Bot mentioned this pull request May 19, 2025
PyUnicode_InternFromString does not immortalize the string as the document claims #133260
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label May 19, 2025
@github-project-automation github-project-automation Bot added this to Docs PRs May 19, 2025
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs May 19, 2025
@encukou encukou added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes docs Documentation in the Doc dir skip news and removed docs Documentation in the Doc dir awaiting core review skip news labels May 19, 2025
kumaraditya303
kumaraditya303 approved these changes May 19, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added the awaiting merge label May 19, 2025
@encukou
encukou merged commit 4109a9c into python:main May 29, 2025
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs May 29, 2025
@miss-islington-app

miss-islington-app Bot commented May 29, 2025

Copy link
Copy Markdown

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label May 29, 2025
@encukou
encukou deleted the gh-133260 branch May 29, 2025 13:37
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 29, 2025
@encukou @miss-islington
pythongh-133260: Remove claim that PyUnicode_InternFromString immorta…
52f53f0 
…lizes (pythonGH-134213)

(cherry picked from commit 4109a9c)

Co-authored-by: Petr Viktorin <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 29, 2025
@encukou @miss-islington
pythongh-133260: Remove claim that PyUnicode_InternFromString immorta…
17f74b4 
…lizes (pythonGH-134213)

(cherry picked from commit 4109a9c)

Co-authored-by: Petr Viktorin <[email protected]>
@bedevere-app

bedevere-app Bot commented May 29, 2025

Copy link
Copy Markdown

GH-134883 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 29, 2025
@bedevere-app

bedevere-app Bot commented May 29, 2025

Copy link
Copy Markdown

GH-134884 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 29, 2025
encukou added a commit that referenced this pull request May 29, 2025
@miss-islington @encukou
[3.14] gh-133260: Remove claim that PyUnicode_InternFromString immort…
2d40dd0 
…alizes (GH-134213) (GH-134883)

(cherry picked from commit 4109a9c)

Co-authored-by: Petr Viktorin <[email protected]>
encukou added a commit that referenced this pull request May 29, 2025
@miss-islington @encukou
[3.13] gh-133260: Remove claim that PyUnicode_InternFromString immort…
a9ba2ec 
…alizes (GH-134213) (GH-134884)

(cherry picked from commit 4109a9c)

Co-authored-by: Petr Viktorin <[email protected]>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@encukou @Pranjal095
pythongh-133260: Remove claim that PyUnicode_InternFromString immorta…
defe241 
…lizes (pythonGH-134213)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@encukou @taegyunkim
pythongh-133260: Remove claim that PyUnicode_InternFromString immorta…
a999247 
…lizes (pythonGH-134213)
gostak-dd pushed a commit to gostak-dd/cpython that referenced this pull request Jun 2, 2026
@encukou @gostak-dd
pythongh-133260: Remove claim that PyUnicode_InternFromString immorta…
c21e384 
…lizes (pythonGH-134213)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@encukou @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.