GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-131798: Split CALL_LIST_APPEND into serveral uops by diegorusso · Pull Request #134240 · python/cpython

Conversation

@diegorusso

@diegorusso diegorusso commented May 19, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Better uop coverage in the JIT optimizer #131798

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@diegorusso
pythongh-133180: Optimize _CALL_LIST_APPEND
83c8b95
@diegorusso
diegorusso requested a review from brandtbucher May 19, 2025 15:11
@diegorusso
diegorusso requested review from Fidget-Spinner and markshannon as code owners May 19, 2025 15:11
@bedevere-app bedevere-app Bot added the awaiting core review label May 19, 2025
@diegorusso diegorusso changed the title gh-133180: Optimize _CALL_LIST_APPEND gh-131798: Optimize _CALL_LIST_APPEND May 19, 2025
@bedevere-app bedevere-app Bot mentioned this pull request May 19, 2025
Better uop coverage in the JIT optimizer #131798
Open
@blurb-it
📜🤖 Added by blurb_it.
cb5fce0
Fidget-Spinner
Fidget-Spinner reviewed May 19, 2025
View reviewed changes
Comment thread Python/bytecodes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@diegorusso diegorusso changed the title gh-131798: Optimize _CALL_LIST_APPEND gh-131798: Split CALL_LIST_APPEND into serveral uops May 19, 2025
@diegorusso
Update 2025-05-19-15-15-58.gh-issue-131798.PCP71j.rst
621ae05
brandtbucher
brandtbucher approved these changes May 19, 2025
View reviewed changes

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Python/bytecodes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 19, 2025
diegorusso and others added 3 commits May 19, 2025 14:39
@diegorusso @brandtbucher
Update Python/bytecodes.c
1570b41 
Co-authored-by: Brandt Bucher <[email protected]>
@diegorusso
Merge branch 'main' into call_list_append
b54bfb4
@diegorusso
update generated files
463d1a2
@diegorusso

diegorusso commented May 19, 2025

Copy link
Copy Markdown
Contributor Author

The failures on macOS will be fixed by: #134224
The Windows error is being worked by @brandtbucher and pushed soon.
brandtbucher reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@diegorusso
diegorusso merged commit 42d03f3 into python:main May 19, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label May 19, 2025
@diegorusso
diegorusso deleted the call_list_append branch May 19, 2025 19:49
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@diegorusso @Pranjal095
pythonGH-131798: Split CALL_LIST_APPEND into several uops (pythonGH-1…
1699e48 
…34240)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@diegorusso @taegyunkim
pythonGH-131798: Split CALL_LIST_APPEND into several uops (pythonGH-1…
7e8cdc1 
…34240)
@efimov-mikhail efimov-mikhail mentioned this pull request Nov 11, 2025
CALL_LIST_APPEND specialization can make no progress #141367
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner left review comments
@brandtbucher brandtbucher brandtbucher approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@diegorusso @Fidget-Spinner @brandtbucher
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.