GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-125843: fix `test_curses.test_attributes` on x86-64 macOS by picnixz · Pull Request #134252 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented May 19, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Apparently, on x86-64 MacOS Intel with and without GIL, test_curses.test_attributes failed, but I don't really know why after looking at the code. So, I'll just check by hand to check what kind of error is actually being returned.

  • Issue: Improve error messages of curses by indicating failed C function #125843

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@picnixz
improve traceback when reporting unexpected curses errors
9f71ec7
@picnixz picnixz added the skip news label May 19, 2025
@bedevere-app bedevere-app Bot mentioned this pull request May 19, 2025
Improve error messages of curses by indicating failed C function #125843
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label May 19, 2025
@picnixz

This comment was marked as resolved.

Sign in to view
@bedevere-bot

This comment was marked as resolved.

Sign in to view
@picnixz
fix compilation
0d01ade
@picnixz picnixz changed the title gh-125843: improve traceback when reporting unexpected curses errors gh-125843: fix test_curses.test_attributes on x86-64 macOS May 19, 2025
@picnixz
fix reporting of derwin errors
8fcdb53
@picnixz

This comment was marked as resolved.

Sign in to view
@bedevere-bot

This comment was marked as resolved.

Sign in to view
@picnixz

picnixz commented May 19, 2025

Copy link
Copy Markdown
Member Author

!buildbot x86-64 MacOS Intel
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented May 19, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @picnixz for commit 8fcdb53 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134252%2Fmerge

The command will test the builders whose names match following regular expression: x86-64 MacOS Intel

The builders matched are:

  • x86-64 MacOS Intel ASAN NoGIL PR
  • x86-64 MacOS Intel NoGIL PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
fix assertion
9c7d960
@picnixz picnixz added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 19, 2025
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 19, 2025
@picnixz
fixup comment
e49e11b
@picnixz picnixz added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 19, 2025
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 19, 2025
@python python deleted a comment from bedevere-bot May 19, 2025
@picnixz
Merge remote-tracking branch 'upstream/main' into patch/curses-checks…
12d8805 
…-125843
@python python deleted a comment from bedevere-bot May 19, 2025
@picnixz
Merge remote-tracking branch 'upstream/main' into patch/curses-checks…
8004b3d 
…-125843
@picnixz picnixz added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 19, 2025
@bedevere-bot

bedevere-bot commented May 19, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @picnixz for commit 8004b3d 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134252%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 19, 2025
picnixz
picnixz commented May 19, 2025
View reviewed changes
Comment thread Modules/_cursesmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
remove dead code
088dc79
@picnixz
picnixz enabled auto-merge (squash) May 20, 2025 08:26
@picnixz
picnixz merged commit e007e62 into python:main May 20, 2025
@bedevere-app bedevere-app Bot removed the awaiting core review label May 20, 2025
@encukou

encukou commented May 20, 2025

Copy link
Copy Markdown
Member

Thank you for the fix!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
picnixz deleted the patch/curses-checks-125843 branch May 20, 2025 10:09
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@picnixz @Pranjal095
pythongh-125843: fix test_curses.test_attributes on x86-64 macOS (p…
3ab90e8 
…ython#134252)

While some `libcurses` functions are meant to return OK on success,
this is not always the case for all implementations. As such, we relax
the checks on the return values and allow any non-ERR value to be
considered equivalent to OK.
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@picnixz @taegyunkim
pythongh-125843: fix test_curses.test_attributes on x86-64 macOS (p…
3fd8fd9 
…ython#134252)

While some `libcurses` functions are meant to return OK on success,
this is not always the case for all implementations. As such, we relax
the checks on the return values and allow any non-ERR value to be
considered equivalent to OK.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@picnixz @bedevere-bot @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.