GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-127146: xfail more Emscripten stack overflows by hoodmane · Pull Request #134358 · python/cpython

Conversation

@hoodmane

@hoodmane hoodmane commented May 20, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Emscripten: Get test suite passing #127146

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hoodmane
pythongh-127146: xfail more Emscripten stack overflows
44f7545
@hoodmane
hoodmane requested review from iritkatriel and markshannon as code owners May 20, 2025 16:30
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label May 20, 2025
@bedevere-app bedevere-app Bot mentioned this pull request May 20, 2025
Emscripten: Get test suite passing #127146
Closed
@bedevere-app bedevere-app Bot added the awaiting review label May 20, 2025
@hoodmane hoodmane added the skip news label May 20, 2025
@hoodmane
Fix test skip in test_io
8ea61fa
freakboy3742
freakboy3742 approved these changes May 20, 2025
View reviewed changes

@freakboy3742 freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels May 20, 2025
@freakboy3742 freakboy3742 added 3.14 bugs and security fixes needs backport to 3.14 bugs and security fixes and removed 3.14 bugs and security fixes labels May 20, 2025
@freakboy3742
freakboy3742 enabled auto-merge (squash) May 20, 2025 18:25
@freakboy3742
freakboy3742 merged commit 91e6a58 into python:main May 20, 2025
@miss-islington-app

miss-islington-app Bot commented May 20, 2025

Copy link
Copy Markdown

Thanks @hoodmane for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label May 20, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2025
@hoodmane @miss-islington
pythongh-127146: xfail more Emscripten stack overflows (pythonGH-134358)
967887f 
Adds some additional test xfails for Emscripten stack overflows. Also corrects a test skip for test_io.
(cherry picked from commit 91e6a58)

Co-authored-by: Hood Chatham <[email protected]>
@bedevere-app

bedevere-app Bot commented May 20, 2025

Copy link
Copy Markdown

GH-134382 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 20, 2025
freakboy3742 pushed a commit that referenced this pull request May 20, 2025
@miss-islington @hoodmane
[3.14] gh-127146: xfail more Emscripten stack overflows (GH-134358) (#…
6f1f871 
…134382)

Adds some additional test xfails for Emscripten stack overflows. Also corrects a test skip for test_io.
(cherry picked from commit 91e6a58)

Co-authored-by: Hood Chatham <[email protected]>
lkollar pushed a commit to lkollar/cpython that referenced this pull request May 26, 2025
@hoodmane @lkollar
pythongh-127146: xfail more Emscripten stack overflows (python#134358)
0e4d90e 
Adds some additional test xfails for Emscripten stack overflows. Also corrects a test skip for test_io.
@hoodmane
hoodmane deleted the emscripten-stack-overflows branch June 16, 2025 22:42
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@hoodmane @Pranjal095
pythongh-127146: xfail more Emscripten stack overflows (python#134358)
8f6e8c4 
Adds some additional test xfails for Emscripten stack overflows. Also corrects a test skip for test_io.
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@hoodmane @taegyunkim
pythongh-127146: xfail more Emscripten stack overflows (python#134358)
44de915 
Adds some additional test xfails for Emscripten stack overflows. Also corrects a test skip for test_io.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes
@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hoodmane @freakboy3742
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.