GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-131798: JIT: replace _LOAD_SMALL_INT with _LOAD_CONST_INLINE_BORROW by Zheaoli · Pull Request #134406 · python/cpython

Conversation

@Zheaoli

@Zheaoli Zheaoli commented May 21, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Signed-off-by: Manjusaka [email protected]

  • Issue: Better uop coverage in the JIT optimizer #131798

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Zheaoli
Zheaoli requested a review from Fidget-Spinner as a code owner May 21, 2025 05:58
@bedevere-app bedevere-app Bot mentioned this pull request May 21, 2025
Better uop coverage in the JIT optimizer #131798
Open
@bedevere-app bedevere-app Bot added the awaiting review label May 21, 2025
@Zheaoli Zheaoli changed the title gh-131798: JIT: replace _LOAD_SMALL_INT with _LOAD_SMALL_INT gh-131798: JIT: replace _LOAD_SMALL_INT with _LOAD_CONST_INLINE_BORROW May 21, 2025
@Zheaoli
pythongh-131798: JIT: replace _LOAD_SMALL_INT with
ee6e90b 
`_LOAD_CONST_INLINE_BORROW`

Signed-off-by: Manjusaka <[email protected]>

add news

Signed-off-by: Manjusaka <[email protected]>

add tests

Signed-off-by: Manjusaka <[email protected]>

fix review idea

Signed-off-by: Manjusaka <[email protected]>
@Zheaoli
Zheaoli force-pushed the manjusaka/const-small-int branch from d2741f1 to ee6e90b Compare May 21, 2025 08:12
brandtbucher
brandtbucher approved these changes May 21, 2025
View reviewed changes

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice optimization! Just a couple of suggestions, then I can merge.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/test/test_capi/test_opt.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/optimizer_bytecodes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels May 21, 2025
brandtbucher
brandtbucher reviewed May 21, 2025
View reviewed changes
Comment thread Python/optimizer_bytecodes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Zheaoli and others added 2 commits May 22, 2025 11:20
@Zheaoli @brandtbucher
Update Lib/test/test_capi/test_opt.py
f8483c1 
Co-authored-by: Brandt Bucher <[email protected]>
@Zheaoli
fix review idea
9188925 
Signed-off-by: Manjusaka <[email protected]>
@Zheaoli
Zheaoli requested a review from brandtbucher May 22, 2025 03:24
@Zheaoli
Merge branch 'main' into manjusaka/const-small-int
e47e066
brandtbucher
brandtbucher approved these changes May 22, 2025
View reviewed changes
@brandtbucher
brandtbucher merged commit 8c5e555 into python:main May 22, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label May 22, 2025
@Zheaoli
Zheaoli deleted the manjusaka/const-small-int branch May 22, 2025 16:58
lkollar pushed a commit to lkollar/cpython that referenced this pull request May 26, 2025
@Zheaoli @lkollar
pythonGH-131798: Turn _LOAD_SMALL_INT into _LOAD_CONST_INLINE_BORROW …
3f8b8a0 
…in the JIT (pythonGH-134406)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@Zheaoli @Pranjal095
pythonGH-131798: Turn _LOAD_SMALL_INT into _LOAD_CONST_INLINE_BORROW …
b80bdc8 
…in the JIT (pythonGH-134406)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@Zheaoli @taegyunkim
pythonGH-131798: Turn _LOAD_SMALL_INT into _LOAD_CONST_INLINE_BORROW …
a34295f 
…in the JIT (pythonGH-134406)
gostak-dd pushed a commit to gostak-dd/cpython that referenced this pull request Jun 2, 2026
@Zheaoli @gostak-dd
pythonGH-131798: Turn _LOAD_SMALL_INT into _LOAD_CONST_INLINE_BORROW …
3cfa9a2 
…in the JIT (pythonGH-134406)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner Fidget-Spinner is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Zheaoli @brandtbucher
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.