GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-132983: Refactor shared code in train_dict and finalize_dict by emmatyping · Pull Request #134432 · python/cpython

Conversation

@emmatyping

@emmatyping emmatyping commented May 21, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This PR refactors shared code between _zstd.train_dict and _zstd.finalize_dict, related to verifying and getting the size and number of samples.

  • Issue: Implement PEP 784 - Adding Zstandard to the Python standard library #132983

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@emmatyping
Refactor shared code in train_dict and finalize_dict
15e754c
@emmatyping emmatyping added skip news needs backport to 3.14 bugs and security fixes labels May 21, 2025
@bedevere-app bedevere-app Bot added the awaiting review label May 21, 2025
@bedevere-app bedevere-app Bot mentioned this pull request May 21, 2025
Implement PEP 784 - Adding Zstandard to the Python standard library #132983
Closed
13 tasks done
gpshead
gpshead approved these changes May 21, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels May 21, 2025
@gpshead
gpshead merged commit c64a214 into python:main May 21, 2025
@miss-islington-app

miss-islington-app Bot commented May 21, 2025

Copy link
Copy Markdown

Thanks @emmatyping for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label May 21, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2025
@emmatyping @miss-islington
pythongh-132983: Refactor shared code in train_dict and finalize_dict (…
24c6f25 
…pythonGH-134432)

Refactor shared code in train_dict and finalize_dict
(cherry picked from commit c64a214)

Co-authored-by: Emma Smith <[email protected]>
@bedevere-app

bedevere-app Bot commented May 21, 2025

Copy link
Copy Markdown

GH-134442 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 21, 2025
gpshead pushed a commit that referenced this pull request May 21, 2025
@miss-islington @emmatyping
[3.14] gh-132983: Refactor shared code in train_dict and finalize_dict (
cdc92cd 
GH-134432) (#134442)

gh-132983: Refactor shared code in train_dict and finalize_dict (GH-134432)

Refactor shared code in train_dict and finalize_dict
(cherry picked from commit c64a214)

Co-authored-by: Emma Smith <[email protected]>
lkollar pushed a commit to lkollar/cpython that referenced this pull request May 26, 2025
@emmatyping @lkollar
pythongh-132983: Refactor shared code in train_dict and finalize_dict (…
76647d2 
…pythonGH-134432)

Refactor shared code in train_dict and finalize_dict
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@emmatyping @Pranjal095
pythongh-132983: Refactor shared code in train_dict and finalize_dict (…
c2cb04b 
…pythonGH-134432)

Refactor shared code in train_dict and finalize_dict
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@emmatyping @taegyunkim
pythongh-132983: Refactor shared code in train_dict and finalize_dict (…
c267e74 
…pythonGH-134432)

Refactor shared code in train_dict and finalize_dict
gostak-dd pushed a commit to gostak-dd/cpython that referenced this pull request Jun 2, 2026
@emmatyping @gostak-dd
pythongh-132983: Refactor shared code in train_dict and finalize_dict (…
8c702a3 
…pythonGH-134432)

Refactor shared code in train_dict and finalize_dict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@emmatyping @gpshead
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.