GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-132983: Fix refleak in zstd dictionary functions by emmatyping · Pull Request #134459 · python/cpython

Conversation

@emmatyping

@emmatyping emmatyping commented May 21, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Missed deallocating the array of samples sizes if an invalid array of samples are provided. h/t to @ericsnowcurrently for spotting the buildbot failure.

  • Issue: Implement PEP 784 - Adding Zstandard to the Python standard library #132983

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@emmatyping
Fix refleak in zstd dictionary functions
a35890b
@emmatyping
emmatyping requested a review from gpshead May 21, 2025 18:43
@bedevere-app bedevere-app Bot mentioned this pull request May 21, 2025
Implement PEP 784 - Adding Zstandard to the Python standard library #132983
Closed
13 tasks done
@bedevere-app bedevere-app Bot added the awaiting review label May 21, 2025
@emmatyping emmatyping added skip news needs backport to 3.14 bugs and security fixes labels May 21, 2025
ericsnowcurrently
ericsnowcurrently approved these changes May 21, 2025
View reviewed changes

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels May 21, 2025
@ericsnowcurrently
ericsnowcurrently enabled auto-merge (squash) May 21, 2025 18:52
@ericsnowcurrently
ericsnowcurrently merged commit fb68776 into python:main May 21, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label May 21, 2025
@miss-islington-app

miss-islington-app Bot commented May 21, 2025

Copy link
Copy Markdown

Thanks @emmatyping for the PR, and @ericsnowcurrently for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2025
@emmatyping @miss-islington
pythongh-132983: Fix refleak in zstd dictionary functions (pythongh-1…
8390ef2 
…34459)

(cherry picked from commit fb68776)

Co-authored-by: Emma Smith <[email protected]>
@bedevere-app

bedevere-app Bot commented May 21, 2025

Copy link
Copy Markdown

GH-134463 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 21, 2025
ericsnowcurrently pushed a commit that referenced this pull request May 21, 2025
@miss-islington @emmatyping
[3.14] gh-132983: Fix refleak in zstd dictionary functions (gh-134463)
11d77d2 
(cherry picked from commit fb68776, AKA gh-134459)

Co-authored-by: Emma Smith <[email protected]>
@emmatyping
emmatyping deleted the zstd-refleak branch May 21, 2025 20:30
@gpshead

gpshead commented May 21, 2025

Copy link
Copy Markdown
Member

Hah, I even looked at the original PR for a dealloc, guess I also missed that case. ❤️
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lkollar pushed a commit to lkollar/cpython that referenced this pull request May 26, 2025
@emmatyping @lkollar
pythongh-132983: Fix refleak in zstd dictionary functions (pythongh-1…
29d616c 
…34459)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@emmatyping @Pranjal095
pythongh-132983: Fix refleak in zstd dictionary functions (pythongh-1…
75e3196 
…34459)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@emmatyping @taegyunkim
pythongh-132983: Fix refleak in zstd dictionary functions (pythongh-1…
1e89100 
…34459)
gostak-dd pushed a commit to gostak-dd/cpython that referenced this pull request Jun 2, 2026
@emmatyping @gostak-dd
pythongh-132983: Fix refleak in zstd dictionary functions (pythongh-1…
c231a62 
…34459)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes
@gpshead gpshead Awaiting requested review from gpshead

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@emmatyping @gpshead @ericsnowcurrently
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.