GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-132983: Make _zstd C code PEP 7 compliant by emmatyping · Pull Request #134605 · python/cpython

Conversation

@emmatyping

@emmatyping emmatyping commented May 24, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Mostly just making sure things are under 80 characters and fixing a few incorrectly placed left braces. I also removed const from instances of _zstd_state* const mod_state since a) it was making some lines go over 80 characters b) it is unnecessary and c) it better matches the CPython style.

This is the final todo left in #132983 🎉

  • Issue: Implement PEP 784 - Adding Zstandard to the Python standard library #132983

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gpshead reacted with hooray emoji stonebig reacted with heart emoji
All reactions
  • 🎉 1 reaction
  • ❤️ 1 reaction
emmatyping added 2 commits May 23, 2025 16:45
@emmatyping
Make _zstd C code PEP 7 compliant
6275ad0
@emmatyping
Wrap a few more lines
0e15503
@emmatyping
emmatyping requested a review from gpshead May 24, 2025 00:05
@emmatyping emmatyping added skip news needs backport to 3.14 bugs and security fixes labels May 24, 2025
@bedevere-app bedevere-app Bot mentioned this pull request May 24, 2025
Implement PEP 784 - Adding Zstandard to the Python standard library #132983
Closed
13 tasks done
@bedevere-app bedevere-app Bot added the awaiting review label May 24, 2025
@emmatyping
Remove trailing whitespace
89825a4
gpshead
gpshead approved these changes May 24, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels May 24, 2025
@gpshead
gpshead merged commit 973b8f6 into python:main May 24, 2025
@miss-islington-app

miss-islington-app Bot commented May 24, 2025

Copy link
Copy Markdown

Thanks @emmatyping for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting merge label May 24, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 24, 2025
@emmatyping @miss-islington
pythongh-132983: Make _zstd C code PEP 7 compliant (pythonGH-134605)
89f718b
Make _zstd C code PEP 7 compliant
(cherry picked from commit 973b8f6)

Co-authored-by: Emma Smith <[email protected]>
@bedevere-app

bedevere-app Bot commented May 24, 2025

Copy link
Copy Markdown

GH-134609 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 24, 2025
@bedevere-bot

bedevere-bot commented May 24, 2025

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows Server 2022 NoGIL 3.x (tier-1) has failed when building commit 973b8f6.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1241/builds/5870) and take a look at the build logs.
  4. Check if the failure is related to this commit (973b8f6) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1241/builds/5870

Failed tests:

  • test_weakref
  • test_venv

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):


Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_venv.py", line 616, in test_multiprocessing
    out, err = check_output([self.envpy(real_env_dir=True), '-c',
               ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        'from multiprocessing import Pool; '
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        'pool = Pool(1); '
        ^^^^^^^^^^^^^^^^^^
        'print(pool.apply_async("Python".lower).get(3)); '
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        'pool.terminate()'])
        ^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_venv.py", line 58, in check_output
    raise subprocess.CalledProcessError(
        p.returncode, cmd, out, err)
subprocess.CalledProcessError: Command '['C:\\Users\\Administrator\\AppData\\Local\\Temp\\test_python_oln4cn7v\\tmp5x1oqj4y\\Scripts\\python3.15t_d.exe', '-c', 'from multiprocessing import Pool; pool = Pool(1); print(pool.apply_async("Python".lower).get(3)); pool.terminate()']' returned non-zero exit status 1.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gpshead pushed a commit that referenced this pull request May 24, 2025
@miss-islington @emmatyping
[3.14] gh-132983: Make _zstd C code PEP 7 compliant (GH-134605) (#134609
38a3824
)

gh-132983: Make _zstd C code PEP 7 compliant (GH-134605)

Make _zstd C code PEP 7 compliant
(cherry picked from commit 973b8f6)

Co-authored-by: Emma Smith <[email protected]>
@emmatyping

emmatyping commented May 24, 2025

Copy link
Copy Markdown
Member Author

Hm, that buildbot failure looks unrelated I think.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@emmatyping @Pranjal095
pythongh-132983: Make _zstd C code PEP 7 compliant (pythonGH-134605)
cc946d8
Make _zstd C code PEP 7 compliant
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@emmatyping @taegyunkim
pythongh-132983: Make _zstd C code PEP 7 compliant (pythonGH-134605)
81f1790
Make _zstd C code PEP 7 compliant
gostak-dd pushed a commit to gostak-dd/cpython that referenced this pull request Jun 2, 2026
@emmatyping @gostak-dd
pythongh-132983: Make _zstd C code PEP 7 compliant (pythonGH-134605)
9cb91b8
Make _zstd C code PEP 7 compliant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@emmatyping @bedevere-bot @gpshead
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.