GeezerVison is showing github.com — gh-132983: Make _zstd C code PEP 7 compliant by emmatyping · Pull Request #134605 · python/cpython
Conversation
emmatyping
commented
May 24, 2025
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Mostly just making sure things are under 80 characters and fixing a few incorrectly placed left braces. I also removed const from instances of _zstd_state* const mod_state since a) it was making some lines go over 80 characters b) it is unnecessary and c) it better matches the CPython style.
This is the final todo left in #132983 🎉
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
gpshead reacted with hooray emoji
stonebig reacted with heart emoji
All reactions
-
🎉
1 reaction
-
❤️
1 reaction
|
Thanks @emmatyping for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️
Hi! The buildbot AMD64 Windows Server 2022 NoGIL 3.x (tier-1) has failed when building commit 973b8f6.
What do you need to do:
- Don't panic.
- Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
- Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1241/builds/5870) and take a look at the build logs.
- Check if the failure is related to this commit (973b8f6) or if it is a false positive.
- If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.
You can take a look at the buildbot page here:
https://buildbot.python.org/#/builders/1241/builds/5870
Failed tests:
Summary of the results of the build (if available):
==
Click to see traceback logs
Traceback (most recent call last):
Traceback (most recent call last):
File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_venv.py", line 616, in test_multiprocessing
out, err = check_output([self.envpy(real_env_dir=True), '-c',
~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
'from multiprocessing import Pool; '
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
'pool = Pool(1); '
^^^^^^^^^^^^^^^^^^
'print(pool.apply_async("Python".lower).get(3)); '
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
'pool.terminate()'])
^^^^^^^^^^^^^^^^^^^^
File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_venv.py", line 58, in check_output
raise subprocess.CalledProcessError(
p.returncode, cmd, out, err)
subprocess.CalledProcessError: Command '['C:\\Users\\Administrator\\AppData\\Local\\Temp\\test_python_oln4cn7v\\tmp5x1oqj4y\\Scripts\\python3.15t_d.exe', '-c', 'from multiprocessing import Pool; pool = Pool(1); print(pool.apply_async("Python".lower).get(3)); pool.terminate()']' returned non-zero exit status 1.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Hm, that buildbot failure looks unrelated I think.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
Make _zstd C code PEP 7 compliant
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
Make _zstd C code PEP 7 compliant
gostak-dd
pushed a commit
to gostak-dd/cpython
that referenced
this pull request
Jun 2, 2026
Make _zstd C code PEP 7 compliant
Reviewers
gpshead
gpshead approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|