GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-130328: Fix WindowsConsoleGetEventTests after gh-133728 by chris-eibl · Pull Request #134660 · python/cpython

Conversation

@chris-eibl

@chris-eibl chris-eibl commented May 25, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes the WindowsConsoleGetEventTests which got broken due to moving wait into get_event in WindowsConsole during #133728.

  • Issue: Pasting in new REPL is slow #130328

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@chris-eibl
fix WindowsConsoleGetEventTests after PR-133728
7f15126
@chris-eibl
chris-eibl requested review from ambv, lysnikolaou and pablogsal as code owners May 25, 2025 16:38
@bedevere-app bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels May 25, 2025
@chris-eibl chris-eibl added skip issue skip news labels May 25, 2025
@ambv ambv changed the title fix WindowsConsoleGetEventTests after PR-133728 GH-130328: Fix WindowsConsoleGetEventTests after gh-133728 May 25, 2025
@ambv ambv removed the skip issue label May 25, 2025
@bedevere-app bedevere-app Bot mentioned this pull request May 25, 2025
Pasting in new REPL is slow #130328
Closed
@ambv

ambv commented May 25, 2025

Copy link
Copy Markdown
Contributor

!buildbot Windows10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented May 25, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ambv for commit 7f15126 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134660%2Fmerge

The command will test the builders whose names match following regular expression: Windows10

The builders matched are:

  • AMD64 Windows10 PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv

ambv commented May 25, 2025

Copy link
Copy Markdown
Contributor

Buildbot looks happy now!
chris-eibl reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv
ambv merged commit 1000283 into python:main May 25, 2025
@bedevere-app bedevere-app Bot removed the awaiting review label May 25, 2025
@ambv ambv added awaiting review needs backport to 3.14 bugs and security fixes labels May 25, 2025
@miss-islington-app

miss-islington-app Bot commented May 25, 2025

Copy link
Copy Markdown

Thanks @chris-eibl for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 25, 2025
@chris-eibl @miss-islington
pythonGH-130328: Fix WindowsConsoleGetEventTests after pythongh-133728 (
0422edf 
pythongh-134660)

(cherry picked from commit 1000283)

Co-authored-by: Chris Eibl <[email protected]>
@bedevere-app

bedevere-app Bot commented May 25, 2025

Copy link
Copy Markdown

GH-134666 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 25, 2025
ambv pushed a commit that referenced this pull request May 25, 2025
@miss-islington @chris-eibl
[3.14] GH-130328: Fix WindowsConsoleGetEventTests after gh-133728 (gh…
6917fbf 
…-134660) (gh-134666)

(cherry picked from commit 1000283)

Co-authored-by: Chris Eibl <[email protected]>
@chris-eibl
chris-eibl deleted the fix_WindowsConsoleGetEventTests branch May 26, 2025 05:55
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@chris-eibl @Pranjal095
pythonGH-130328: Fix WindowsConsoleGetEventTests after pythongh-133728 (
c248bcb 
pythongh-134660)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@chris-eibl @taegyunkim
pythonGH-130328: Fix WindowsConsoleGetEventTests after pythongh-133728 (
3a120b1 
pythongh-134660)
gostak-dd pushed a commit to gostak-dd/cpython that referenced this pull request Jun 2, 2026
@chris-eibl @gostak-dd
pythonGH-130328: Fix WindowsConsoleGetEventTests after pythongh-133728 (
0d7b88f 
pythongh-134660)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
@ambv ambv Awaiting requested review from ambv ambv is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@chris-eibl @ambv @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.