GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-91048: Correct Apple platform includes for iOS by freakboy3742 · Pull Request #134712 · python/cpython

Conversation

@freakboy3742

@freakboy3742 freakboy3742 commented May 26, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

#134652 introduced some modifications to support remote debugging; however the platform #defines (in particular the ones on L103, L138 and L170) was incorrectly including iOS in the usage, but not in the definition of the pid_to_task symbol.

The pid_to_task implementation depends on libproc.h and mach/mach-vm.h, which aren't available on iOS.

  • Issue: Async Call-Stack Reconstruction #91048

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@freakboy3742
Correct Apple platform includes for iOS.
c5f5619
@bedevere-app bedevere-app Bot mentioned this pull request May 26, 2025
Excess spaces at the end of files or repositorys are not handle when extracting zip files on Windows. #94018
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label May 26, 2025
@freakboy3742 freakboy3742 added skip news needs backport to 3.14 bugs and security fixes and removed awaiting core review labels May 26, 2025
@freakboy3742

freakboy3742 commented May 26, 2025

Copy link
Copy Markdown
Contributor Author

!buildbot iOS
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented May 26, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit c5f5619 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134712%2Fmerge

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@freakboy3742
freakboy3742 requested a review from pablogsal May 26, 2025 12:15
@hugovk hugovk added the awaiting core review label May 26, 2025
@freakboy3742 freakboy3742 changed the title gh-94018: Correct Apple platform includes for iOS. gh-91048: Correct Apple platform includes for iOS. May 26, 2025
@bedevere-app bedevere-app Bot mentioned this pull request May 26, 2025
Async Call-Stack Reconstruction #91048
Closed
pablogsal
pablogsal approved these changes May 26, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 26, 2025
@freakboy3742
freakboy3742 enabled auto-merge (squash) May 26, 2025 12:23
@AA-Turner AA-Turner changed the title gh-91048: Correct Apple platform includes for iOS. gh-91048: Correct Apple platform includes for iOS May 26, 2025
@freakboy3742
freakboy3742 merged commit 965662e into python:main May 26, 2025
@freakboy3742
freakboy3742 deleted the fix-apple-includes branch May 26, 2025 12:44
@miss-islington-app

miss-islington-app Bot commented May 26, 2025

Copy link
Copy Markdown

Thanks @freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label May 26, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 26, 2025
@freakboy3742 @miss-islington
pythongh-91048: Correct Apple platform includes for iOS. (pythonGH-13…
25493d3 
…4712)

Correct Apple platform includes for iOS.
(cherry picked from commit 965662e)

Co-authored-by: Russell Keith-Magee <[email protected]>
@bedevere-app

bedevere-app Bot commented May 26, 2025

Copy link
Copy Markdown

GH-134714 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 26, 2025
freakboy3742 added a commit that referenced this pull request May 26, 2025
@miss-islington @freakboy3742
[3.14] gh-91048: Correct Apple platform includes for iOS. (GH-134712) (…
6c917cb 
…#134714)

Correct Apple platform includes for iOS.
(cherry picked from commit 965662e)

Co-authored-by: Russell Keith-Magee <[email protected]>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@freakboy3742 @Pranjal095
pythongh-91048: Correct Apple platform includes for iOS. (python#134712)
4312701 
Correct Apple platform includes for iOS.
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@freakboy3742 @taegyunkim
pythongh-91048: Correct Apple platform includes for iOS. (python#134712)
62c3206 
Correct Apple platform includes for iOS.
gostak-dd pushed a commit to gostak-dd/cpython that referenced this pull request Jun 2, 2026
@freakboy3742 @gostak-dd
pythongh-91048: Correct Apple platform includes for iOS. (python#134712)
5139145 
Correct Apple platform includes for iOS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@freakboy3742 @bedevere-bot @pablogsal @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.