GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] GH-128161: Remove redundant GET_ITER from list comprehension code by markshannon · Pull Request #134778 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented May 27, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Defining iterator in a separate class no longer works in 3.13 #128161

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
efimov-mikhail reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@markshannon
markshannon requested a review from iritkatriel as a code owner May 27, 2025 08:21
@bedevere-app bedevere-app Bot added the awaiting core review label May 27, 2025
@bedevere-app bedevere-app Bot mentioned this pull request May 27, 2025
Defining iterator in a separate class no longer works in 3.13 #128161
Closed
@markshannon markshannon added needs backport to 3.13 only security fixes and removed awaiting core review labels May 27, 2025
@markshannon
Remove redundant GET_ITER from list comprehension code
0e39bd3
@markshannon
markshannon force-pushed the dedup-getiter-listcomp branch from e3d638b to 0e39bd3 Compare May 27, 2025 09:00
@markshannon

markshannon commented May 27, 2025

Copy link
Copy Markdown
Member Author

This is for 3.14 and 3.13 only as #132555 contains the fix for 3.15
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel
iritkatriel reviewed May 27, 2025
View reviewed changes
Comment thread Lib/test/test_listcomps.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel

iritkatriel commented May 27, 2025

Copy link
Copy Markdown
Member

Do we have a test with the case described in the issue (#128161)?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@markshannon

markshannon commented May 27, 2025

Copy link
Copy Markdown
Member Author

Do we have a test with the case described in the issue (#128161)?

Yes, that's the new test added.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
markshannon added 2 commits May 27, 2025 11:29
@markshannon
Add test for async list comprehension
7a05f9a
@markshannon
Fix whitespace
76ac299
iritkatriel
iritkatriel approved these changes May 27, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added the awaiting merge label May 27, 2025
@markshannon
markshannon merged commit 00122c8 into python:3.14 May 27, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label May 27, 2025
@miss-islington-app

miss-islington-app Bot commented May 27, 2025

Copy link
Copy Markdown

Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@markshannon
markshannon deleted the dedup-getiter-listcomp branch May 27, 2025 11:29
@miss-islington-app

miss-islington-app Bot commented May 27, 2025

Copy link
Copy Markdown

Sorry, @markshannon, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 00122c8b2ab7c402daa144bb498e3a4f33254055 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned markshannon May 27, 2025
markshannon added a commit to faster-cpython/cpython that referenced this pull request May 27, 2025
@markshannon
[3.14] pythonGH-128161: Remove redundant GET_ITER from list comprehen…
9000bd4 
…sion code (pythonGH-134778)
@bedevere-app

bedevere-app Bot commented May 27, 2025

Copy link
Copy Markdown

GH-134788 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 27, 2025
markshannon added a commit that referenced this pull request May 27, 2025
@markshannon
[3.13] gh-128161: Remove redundant GET_ITER from list comprehension c…
814ac0d 
…ode (backport of GH-134778) (GH-134788)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@markshannon markshannon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@markshannon @iritkatriel
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.