GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] gh-91048: Reorder result tuple of parse_code_object (GH-134898) by miss-islington · Pull Request #134956 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented May 31, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Reorder result tuple of parse_code_object

The standard followed by APIs like pstat.Stats is to take a file, line,
function triplet. The parse_code_object function (and callers exposing
this in Python like RemoteUnwinder.get_stack_trace) return function,
file, line triplets which requires the caller to reorder these when
using it in classes like pstat.Stats.
(cherry picked from commit 8e8786f)

Co-authored-by: László Kiss Kollár [email protected]

  • Issue: Async Call-Stack Reconstruction #91048

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@lkollar @miss-islington
pythongh-91048: Reorder result tuple of parse_code_object (pythonGH-1…
7e38e37
…34898)

Reorder result tuple of parse_code_object

The standard followed by APIs like pstat.Stats is to take a file, line,
function triplet. The parse_code_object function (and callers exposing
this in Python like RemoteUnwinder.get_stack_trace) return function,
file, line triplets which requires the caller to reorder these when
using it in classes like pstat.Stats.
(cherry picked from commit 8e8786f)

Co-authored-by: László Kiss Kollár <[email protected]>
@miss-islington
miss-islington requested review from 1st1, ambv and pablogsal as code owners May 31, 2025 00:32
@bedevere-app bedevere-app Bot mentioned this pull request May 31, 2025
Async Call-Stack Reconstruction #91048
Closed
@bedevere-app bedevere-app Bot added the skip news label May 31, 2025
@bedevere-app bedevere-app Bot mentioned this pull request May 31, 2025
gh-91048: Reorder result tuple of parse_code_object #134898
Merged
@bedevere-app bedevere-app Bot added the awaiting review label May 31, 2025
pablogsal
pablogsal approved these changes May 31, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels May 31, 2025
@pablogsal
Reorder asyncio
40ca6bd
@pablogsal
pablogsal requested review from asvetlov, kumaraditya303 and willingc as code owners May 31, 2025 00:53
@pablogsal
pablogsal enabled auto-merge (squash) May 31, 2025 00:54
@pablogsal
update test tools
ecc8a21
@pablogsal
pablogsal merged commit f303532 into python:3.14 Jun 11, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 11, 2025
@miss-islington
miss-islington deleted the backport-8e8786f-3.14 branch January 2, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@ambv ambv Awaiting requested review from ambv ambv is a code owner
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303
@willingc willingc Awaiting requested review from willingc

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @pablogsal @lkollar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.