GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-91048: Reorder result tuple of parse_code_object by lkollar · Pull Request #134898 · python/cpython

Conversation

@lkollar

@lkollar lkollar commented May 29, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The standard followed by APIs like pstat.Stats is to take a file, line, function triplet. The parse_code_object function (and callers exposing this in Python like RemoteUnwinder.get_stack_trace) return function, file, line triplets which requires the caller to reorder these when using it in classes like pstat.Stats.

  • Issue: Async Call-Stack Reconstruction #91048

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@lkollar
Reorder result tuple of parse_code_object
58e9e03
The standard followed by APIs like pstat.Stats is to take a file, line,
function triplet. The parse_code_object function (and callers exposing
this in Python like RemoteUnwinder.get_stack_trace) return function,
file, line triplets which requires the caller to reorder these when
using it in classes like pstat.Stats.
@lkollar
lkollar force-pushed the reorder-stack-frames branch from b128a06 to 58e9e03 Compare May 30, 2025 06:46
@lkollar lkollar changed the title Reorder result tuple of parse_code_object gh-91048: Reorder result tuple of parse_code_object May 30, 2025
@bedevere-app bedevere-app Bot mentioned this pull request May 30, 2025
Async Call-Stack Reconstruction #91048
Closed
@lkollar
lkollar marked this pull request as ready for review May 30, 2025 06:54
@lkollar
lkollar requested review from 1st1, ambv and pablogsal as code owners May 30, 2025 06:54
@bedevere-app bedevere-app Bot added the awaiting review label May 30, 2025
@pablogsal pablogsal added skip news needs backport to 3.14 bugs and security fixes labels May 31, 2025
pablogsal
pablogsal approved these changes May 31, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels May 31, 2025
@pablogsal
pablogsal enabled auto-merge (squash) May 31, 2025 00:32
@pablogsal
pablogsal merged commit 8e8786f into python:main May 31, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label May 31, 2025
@miss-islington-app

miss-islington-app Bot commented May 31, 2025

Copy link
Copy Markdown

Thanks @lkollar for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 31, 2025
@lkollar @miss-islington
pythongh-91048: Reorder result tuple of parse_code_object (pythonGH-1…
7e38e37
…34898)

Reorder result tuple of parse_code_object

The standard followed by APIs like pstat.Stats is to take a file, line,
function triplet. The parse_code_object function (and callers exposing
this in Python like RemoteUnwinder.get_stack_trace) return function,
file, line triplets which requires the caller to reorder these when
using it in classes like pstat.Stats.
(cherry picked from commit 8e8786f)

Co-authored-by: László Kiss Kollár <[email protected]>
@bedevere-app

bedevere-app Bot commented May 31, 2025

Copy link
Copy Markdown

GH-134956 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 31, 2025
@lkollar
lkollar deleted the reorder-stack-frames branch June 7, 2025 17:50
pablogsal added a commit that referenced this pull request Jun 11, 2025
@miss-islington @lkollar @pablogsal
[3.14] gh-91048: Reorder result tuple of parse_code_object (GH-134898) (
f303532
#134956)

* gh-91048:  Reorder result tuple of parse_code_object (GH-134898)

Reorder result tuple of parse_code_object

The standard followed by APIs like pstat.Stats is to take a file, line,
function triplet. The parse_code_object function (and callers exposing
this in Python like RemoteUnwinder.get_stack_trace) return function,
file, line triplets which requires the caller to reorder these when
using it in classes like pstat.Stats.
(cherry picked from commit 8e8786f)

Co-authored-by: László Kiss Kollár <[email protected]>

* Reorder asyncio

---------

Co-authored-by: László Kiss Kollár <[email protected]>
Co-authored-by: Pablo Galindo <[email protected]>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@lkollar @Pranjal095
pythongh-91048: Reorder result tuple of parse_code_object (python#134898
4490c33
)

Reorder result tuple of parse_code_object

The standard followed by APIs like pstat.Stats is to take a file, line,
function triplet. The parse_code_object function (and callers exposing
this in Python like RemoteUnwinder.get_stack_trace) return function,
file, line triplets which requires the caller to reorder these when
using it in classes like pstat.Stats.
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@lkollar @taegyunkim
pythongh-91048: Reorder result tuple of parse_code_object (python#134898
79dc8f6
)

Reorder result tuple of parse_code_object

The standard followed by APIs like pstat.Stats is to take a file, line,
function triplet. The parse_code_object function (and callers exposing
this in Python like RemoteUnwinder.get_stack_trace) return function,
file, line triplets which requires the caller to reorder these when
using it in classes like pstat.Stats.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@ambv ambv Awaiting requested review from ambv
@1st1 1st1 Awaiting requested review from 1st1

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@lkollar @pablogsal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.