GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-134696: align OpenSSL and HACL*-based hash functions constructors AC signatures (GH-134713) by picnixz · Pull Request #134962 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented May 31, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

OpenSSL and HACL*-based hash functions constructors now support both data and string parameters. Previously these constructor functions inconsistently supported sometimes data and sometimes string, while the documentation expected data to be given in all cases.

(cherry picked from commit c6e63d9 and 379d0bc)

  • Issue: Clinic signatures of HACL* hash functions are inconsistent with OpenSSL implementation #134696

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@picnixz
picnixz requested review from gpshead and tiran as code owners May 31, 2025 07:55
@bedevere-app bedevere-app Bot mentioned this pull request May 31, 2025
Clinic signatures of HACL* hash functions are inconsistent with OpenSSL implementation #134696
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label May 31, 2025
@bedevere-app bedevere-app Bot mentioned this pull request May 31, 2025
gh-134696: align OpenSSL and HACL*-based hash functions constructors AC signatures #134713
Merged
@picnixz
[3.13] pythongh-134696: align OpenSSL and HACL*-based hash functions …
ad4c913 
…constructors AC signatures (pythonGH-134713)

OpenSSL and HACL*-based hash functions constructors now support both `data` and `string` parameters.
Previously these constructor functions inconsistently supported sometimes `data` and sometimes `string`,
while the documentation expected `data` to be given in all cases.

(cherry picked from commit c6e63d9)
(cherry picked from commit 379d0bc)

Co-authored-by: Bénédikt Tran <[email protected]>
@picnixz
picnixz force-pushed the backport-c6e63d9-3.13 branch from d332225 to ad4c913 Compare May 31, 2025 13:22
@picnixz picnixz added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 31, 2025
@bedevere-bot

bedevere-bot commented May 31, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @picnixz for commit ad4c913 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134962%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 31, 2025
@picnixz picnixz mentioned this pull request May 31, 2025
gh-134696: fix hashlib FIPS-only BLAKE-2 buildbot #134968
Merged
@picnixz
picnixz merged commit 2c325e2 into python:3.13 Jun 1, 2025
@picnixz
picnixz deleted the backport-c6e63d9-3.13 branch June 1, 2025 08:27
@bedevere-app bedevere-app Bot removed the awaiting core review label Jun 1, 2025
@brianschubert brianschubert mentioned this pull request Jun 7, 2025
Daily tests failed on Sat Jun 07 2025 python/typeshed#14229
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner
@tiran tiran Awaiting requested review from tiran

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@picnixz @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.