GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-134696: fix `hashlib` FIPS-only BLAKE-2 buildbot by picnixz · Pull Request #134968 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented May 31, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I've also added a bit more testing because I observed I wasn't testing .new explicitly.

This doesn't need backports as I directly included this commit into #134961 and #134962.

  • Issue: Clinic signatures of HACL* hash functions are inconsistent with OpenSSL implementation #134696

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gpshead reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@picnixz
fix FIPS-only tests
e242abc
@picnixz picnixz added the skip news label May 31, 2025
@picnixz
picnixz requested review from gpshead and tiran as code owners May 31, 2025 09:37
@bedevere-app bedevere-app Bot added the awaiting core review label May 31, 2025
@bedevere-app bedevere-app Bot mentioned this pull request May 31, 2025
Clinic signatures of HACL* hash functions are inconsistent with OpenSSL implementation #134696
Closed
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label May 31, 2025
@picnixz

picnixz commented May 31, 2025

Copy link
Copy Markdown
Member Author

!buildbot FIPS
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented May 31, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @picnixz for commit e242abc 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134968%2Fmerge

The command will test the builders whose names match following regular expression: FIPS

The builders matched are:

  • AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR
  • AMD64 CentOS9 FIPS Only Blake2 Builtin Hash PR
  • AMD64 RHEL8 FIPS No Builtin Hashes PR
  • AMD64 CentOS9 FIPS No Builtin Hashes PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz picnixz changed the title gh-134696: fix hashlib FIPS-only buildbot gh-134696: fix hashlib FIPS-only BLAKE-2 buildbot May 31, 2025
@picnixz

picnixz commented May 31, 2025

Copy link
Copy Markdown
Member Author

Bots without Blake2 are also known to fail.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
picnixz merged commit 379d0bc into python:main May 31, 2025
@picnixz
picnixz deleted the fix/hashlib/tests-134696 branch May 31, 2025 10:48
@bedevere-app bedevere-app Bot removed the awaiting core review label May 31, 2025
picnixz added a commit to picnixz/cpython that referenced this pull request May 31, 2025
@picnixz
pythongh-134696: fix hashlib tests for FIPS-only BLAKE-2 buildbot (p…
622dea0 
…ython#134968)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@picnixz @Pranjal095
pythongh-134696: fix hashlib tests for FIPS-only BLAKE-2 buildbot (p…
bac898b 
…ython#134968)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@picnixz @taegyunkim
pythongh-134696: fix hashlib tests for FIPS-only BLAKE-2 buildbot (p…
5e8fec9 
…ython#134968)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner
@tiran tiran Awaiting requested review from tiran

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@picnixz @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.