GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-134978: deprecate `string` keyword parameter for hash function constructors by picnixz · Pull Request #134979 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented May 31, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Deprecate support for string named-parameter in hash functions constructors #134978

📚 Documentation preview 📚: https://cpython-previews--134979.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@picnixz
picnixz requested review from gpshead and tiran as code owners May 31, 2025 14:06
@bedevere-app bedevere-app Bot added the awaiting core review label May 31, 2025
@bedevere-app bedevere-app Bot mentioned this pull request May 31, 2025
Deprecate support for string named-parameter in hash functions constructors #134978
Closed
@picnixz

picnixz commented May 31, 2025

Copy link
Copy Markdown
Member Author

Oh I forgot to update hashlib.rst

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@picnixz
picnixz force-pushed the feat/hashlib/deprecate-string-parameter-134978 branch from 005a637 to 996992d Compare May 31, 2025 14:09
@picnixz
deprecate string keyword parameter for hash function constructors
26f01fa
@picnixz
picnixz force-pushed the feat/hashlib/deprecate-string-parameter-134978 branch from 996992d to 26f01fa Compare May 31, 2025 14:09
gpshead
gpshead reviewed May 31, 2025
View reviewed changes

@gpshead gpshead left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets extend the timeline longer than our minimal 2 years. how about 3.19?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Doc/deprecations/pending-removal-in-3.17.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

picnixz added 2 commits June 1, 2025 10:36
@picnixz
amend deprecation notes
ae0e0c3
@picnixz
update warning
7f87b05
picnixz
picnixz commented Jun 1, 2025
View reviewed changes
Comment thread Doc/library/hashlib.rst
the `HACL\* project`_.

.. deprecated-removed:: 3.15 3.19
The undocumented ``string`` keyword parameter in :func:`!_hashlib.new`

@picnixz picnixz Jun 1, 2025

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This deprecation note is about the private interface (except for the public hashlib.sha3_*, 'string' was only present in private functions), so I still mentioned this here. There were too many situations where people complained that a deprecation note was only in present in the What's New or changelog, but not in the page documenting the functions (though in this case, the only documented functions being affected are sha3_* or hashlib.new + sha3 + HACL*)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gpshead reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@picnixz
picnixz requested a review from gpshead June 1, 2025 08:40
@gpshead
3.19 in the warning
80ce66d
gpshead
gpshead approved these changes Jun 2, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jun 2, 2025
@picnixz
picnixz merged commit ee65ebd into python:main Jun 2, 2025
@picnixz
picnixz deleted the feat/hashlib/deprecate-string-parameter-134978 branch June 2, 2025 08:25
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 2, 2025
@bedevere-bot

bedevere-bot commented Jun 2, 2025

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 MacOS M1 Refleaks NoGIL 3.x (tier-2) has failed when building commit ee65ebd.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1368/builds/3296) and take a look at the build logs.
  4. Check if the failure is related to this commit (ee65ebd) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1368/builds/3296

Failed tests:

  • test.test_concurrent_futures.test_interpreter_pool

Failed subtests:

  • test_free_reference - test.test_concurrent_futures.test_interpreter_pool.InterpreterPoolExecutorTest.test_free_reference

Test leaking resources:

  • test_interpreter_pool: memory blocks

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-arm64-aws.macos-with-brew.refleak.nogil/build/Lib/test/test_concurrent_futures/executor.py", line 220, in test_free_reference
    for _ in support.sleeping_retry(support.SHORT_TIMEOUT):
             ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-arm64-aws.macos-with-brew.refleak.nogil/build/Lib/test/support/__init__.py", line 2590, in sleeping_retry
    for _ in busy_retry(timeout, err_msg, error=error):
             ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-arm64-aws.macos-with-brew.refleak.nogil/build/Lib/test/support/__init__.py", line 2560, in busy_retry
    raise AssertionError(msg)
AssertionError: timeout (67.9 seconds)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@picnixz @Pranjal095
pythongh-134978: deprecate string keyword parameter for hash functi…
b2d4cb8
…on constructors (python#134979)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@picnixz @taegyunkim
pythongh-134978: deprecate string keyword parameter for hash functi…
e8f0a38
…on constructors (python#134979)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@picnixz @Agent-Hellboy
pythongh-134978: deprecate string keyword parameter for hash functi…
2cdc42c
…on constructors (python#134979)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes
@tiran tiran Awaiting requested review from tiran

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@picnixz @bedevere-bot @gpshead
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.