GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — bpo-28787: Fix out of tree --with-dtrace builds by stratakis · Pull Request #135 · python/cpython

Conversation

stratakis commented Feb 16, 2017

Copy link

Copy Markdown

Contributor

Issue reported at: https://bugs.python.org/issue28787

This was observed after DTrace and Systemtap support was introduced for Python 3.6.0: https://bugs.python.org/issue21590

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

the-knights-who-say-ni added the CLA signed label

Feb 16, 2017

vstinner requested changes

May 5, 2017

View reviewed changes

vstinner left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be your first contribution, please add yourself to Misc/ACKS ;-)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Makefile.pre.in Outdated

vstinner May 5, 2017

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove @, I like to see what is done.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vstinner commented May 5, 2017

Copy link

Copy Markdown

Member

Please rebase also your change.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

stratakis added 3 commits

May 9, 2017 15:18


          bpo-28787: Fix out of tree --with-dtrace builds

b568956


          Unsilence directory creation

8de6a09


          Add Misc/NEWS and Misc/ACKS entries

fea9af6

stratakis force-pushed the out_of_tree_dtrace branch from 845b707 to fea9af6 Compare

May 9, 2017 13:33

stratakis mentioned this pull request

May 9, 2017

[3.6] bpo-28787: Fix out of tree --with-dtrace builds #1519

Closed

vstinner approved these changes

May 10, 2017

View reviewed changes

vstinner merged commit f6eae5b into python:master

May 10, 2017

vstinner commented May 10, 2017

Copy link

Copy Markdown

Member

I merged your change, thanks @stratakis. Would you mind to backport the change? Only 3.6 is needed according to http://bugs.python.org/issue28787

I used the following commands. Without the change, make fails. With the fix, make works as expected.

cd $HOME
rm -rf build_cpython/
mkdir build_cpython/
cd build_cpython/
~/prog/python/master/configure --with-pydebug --with-dtrace
make

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

stratakis commented May 10, 2017

Copy link

Copy Markdown

Contributor Author

Thanks @Haypo . I have already backported the change at #1519 .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

stratakis added a commit to stratakis/cpython that referenced this pull request

May 11, 2017


          [3.6] bpo-28787: Fix out of tree --with-dtrace builds (pythonGH-135)

5b7bcbf

* bpo-28787: Fix out of tree --with-dtrace builds

* Unsilence directory creation

* Add Misc/NEWS and Misc/ACKS entries.
(cherry picked from commit f6eae5b)

vstinner pushed a commit that referenced this pull request

May 11, 2017


          [3.6] bpo-28787: Fix out of tree --with-dtrace builds (GH-135) (#1543)

a4465a5

* bpo-28787: Fix out of tree --with-dtrace builds

* Unsilence directory creation

* Add Misc/NEWS and Misc/ACKS entries.
(cherry picked from commit f6eae5b)

akruis pushed a commit to akruis/cpython that referenced this pull request

Oct 10, 2017


          Merge branch master into master-slp

709c150

This commit reveals a reference leak. See issue python#135,
stackless-dev#135

akruis pushed a commit to akruis/cpython that referenced this pull request

Oct 10, 2017


          Issue python#135: fix memory leaks of types with Stackless extensions.

e217840

Fix several problems related with slp_prepare_slots():
- set Py_TPFLAGS_HAVE_STACKLESS_EXTENSION in slp_prepare_slots().
- for heap types free the allocated buffer in tp_dealloc
- Allocate the memory from the object domain, because the blocks are
  small (about 74 bytes).

akruis pushed a commit to akruis/cpython that referenced this pull request

Oct 29, 2017


          Stackless issues python#135, python#136: update changelog.txt

f845a0f

akruis pushed a commit to akruis/cpython that referenced this pull request

Jun 19, 2018


          Issue python#135: fix memory leaks of types with Stackless extensions.

39d3781

Fix several problems related with slp_prepare_slots():
- set Py_TPFLAGS_HAVE_STACKLESS_EXTENSION in slp_prepare_slots().
- for heap types free the allocated buffer in tp_dealloc
- Allocate the memory from the object domain, because the blocks are
  small (about 74 bytes).

(cherry picked from commit e217840)

stratakis deleted the out_of_tree_dtrace branch

January 3, 2020 21:28

jaraco pushed a commit that referenced this pull request

Dec 2, 2022


          Update aiohttp from 3.3.2 to 3.4.0 (#135)

58caceb

gvanrossum mentioned this pull request

Aug 22, 2023

heap-use-after-free in _PyFunction_LookupByVersion #108253

Closed

This was referenced Feb 11, 2025

segmentfault when pip installing setuptools #129992

Closed

segmentfault when pip installing setuptools #129993

Closed

Reviewers

vstinner

vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.