GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-134160: Use PyModuleDef.m_free in the example module xxlimited by encukou · Pull Request #135174 · python/cpython

Conversation

@encukou

@encukou encukou commented Jun 5, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The comment about free not being necessary is wrong. Like classes, modules need both clear and free.

  • Issue: Docs Examples Focus on Outdated Single-Phase Init Modules and Static Types #134160

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
neonene and Elkiwa reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@encukou
Use PyModuleDef.m_free in the example module xxlimited
500d570
@encukou encukou added the skip news label Jun 5, 2025
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 5, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jun 5, 2025
Docs Examples Focus on Outdated Single-Phase Init Modules and Static Types #134160
Open
@encukou encukou added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Jun 5, 2025
neonene
neonene reviewed Jun 6, 2025
View reviewed changes
Comment thread Modules/xxlimited.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@encukou @neonene
Update Modules/xxlimited.c
f89c4fb 
Co-authored-by: neonene <[email protected]>
@encukou
encukou enabled auto-merge (squash) June 6, 2025 11:48
vstinner
vstinner approved these changes Jun 6, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

You should merge main into your branch to retrieve the test_syntax fix.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
encukou reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jun 6, 2025
@encukou
Merge branch 'main' into xxlimited-free
bf42196
@encukou
encukou merged commit 1adca08 into python:main Jun 6, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 6, 2025
@miss-islington-app

miss-islington-app Bot commented Jun 6, 2025

Copy link
Copy Markdown

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 6, 2025
@encukou @neonene @miss-islington
pythongh-134160: Use PyModuleDef.m_free in the example module xxlimit…
cff4bbf 
…ed (pythonGH-135174)

(cherry picked from commit 1adca08)

Co-authored-by: Petr Viktorin <[email protected]>
Co-authored-by: neonene <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 6, 2025
@encukou @neonene @miss-islington
pythongh-134160: Use PyModuleDef.m_free in the example module xxlimit…
986354f 
…ed (pythonGH-135174)

(cherry picked from commit 1adca08)

Co-authored-by: Petr Viktorin <[email protected]>
Co-authored-by: neonene <[email protected]>
@bedevere-app

bedevere-app Bot commented Jun 6, 2025

Copy link
Copy Markdown

GH-135213 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 6, 2025
@bedevere-app

bedevere-app Bot commented Jun 6, 2025

Copy link
Copy Markdown

GH-135214 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jun 6, 2025
encukou added a commit that referenced this pull request Jun 6, 2025
@miss-islington @encukou @neonene
[3.14] gh-134160: Use PyModuleDef.m_free in the example module xxlimi…
dd4a819 
…ted (GH-135174) (GH-135213)

gh-134160: Use PyModuleDef.m_free in the example module xxlimited (GH-135174)
(cherry picked from commit 1adca08)

Co-authored-by: Petr Viktorin <[email protected]>
Co-authored-by: neonene <[email protected]>
@encukou
encukou deleted the xxlimited-free branch June 7, 2025 09:03
encukou added a commit that referenced this pull request Jun 7, 2025
@miss-islington @encukou @neonene
[3.13] gh-134160: Use PyModuleDef.m_free in the example module xxlimi…
7620805 
…ted (GH-135174) (GH-135214)

gh-134160: Use PyModuleDef.m_free in the example module xxlimited (GH-135174)
(cherry picked from commit 1adca08)

Co-authored-by: Petr Viktorin <[email protected]>
Co-authored-by: neonene <[email protected]>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@encukou @neonene @Pranjal095
pythongh-134160: Use PyModuleDef.m_free in the example module xxlimit…
4277371 
…ed (pythonGH-135174)

Co-authored-by: neonene <[email protected]>
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@encukou @neonene @taegyunkim
pythongh-134160: Use PyModuleDef.m_free in the example module xxlimit…
461148b 
…ed (pythonGH-135174)

Co-authored-by: neonene <[email protected]>
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@encukou @neonene @Agent-Hellboy
pythongh-134160: Use PyModuleDef.m_free in the example module xxlimit…
5fe9e83 
…ed (pythonGH-135174)

Co-authored-by: neonene <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
+1 more reviewer
@neonene neonene neonene left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@encukou @vstinner @neonene
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.