GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — GH-132661: Add ``string.templatelib.convert()`` by AA-Turner · Pull Request #135217 · python/cpython

Conversation

AA-Turner commented Jun 6, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

See https://discuss.python.org/t/94569/. cc @davepeck @treyhunner.

Sketch implementation. Skip news as this would be part of the larger PEP 750 piece.

Issue: Implement PEP 750 – Template Strings #132661

📚 Documentation preview 📚: https://cpython-previews--135217.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

davepeck, johnslavik, treyhunner, nineteendo, and ThiefMaster reacted with heart emoji

All reactions

❤️ 5 reactions


          Add string.templatelib.convert()

d91d6fc

AA-Turner requested a review from lysnikolaou as a code owner

June 6, 2025 14:53

bedevere-app Bot added the awaiting core review label

Jun 6, 2025

bedevere-app Bot mentioned this pull request

Jun 6, 2025

Implement PEP 750 – Template Strings #132661

Closed

AA-Turner added the skip news label

Jun 6, 2025

lysnikolaou commented Jul 10, 2025

Copy link

Copy Markdown

Member

There's some test failures here. @hugovk Would it be okay if we backported this to 3.14?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lysnikolaou reviewed

Jul 10, 2025

View reviewed changes

lysnikolaou left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just add string.templatelib.convert in this PR and leave docs for the big docs PR that currently in review.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

davepeck reacted with thumbs up emoji

All reactions

👍 1 reaction

hugovk commented Jul 11, 2025

Copy link

Copy Markdown

Member

@hugovk Would it be okay if we backported this to 3.14?

Yes, this makes sense to be part of the PEP 750 stuff. RC1 is soon: 2025-07-22.

AA-Turner and lysnikolaou reacted with thumbs up emoji

All reactions

👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lysnikolaou commented Jul 15, 2025

Copy link

Copy Markdown

Member

@AA-Turner Are you going to work on this to simplify it down to just adding convert?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AA-Turner commented Jul 15, 2025

Copy link

Copy Markdown

Member Author

Yes, sorry (at EuroPython). Hopefully will have time this afternoon.

lysnikolaou and davepeck reacted with heart emoji

All reactions

❤️ 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AA-Turner added 3 commits

July 15, 2025 09:43


          Remove documentation

321164a


          Avoid BytesWarning

9d59705


          Imperative mood

125ce4e

AA-Turner requested a review from lysnikolaou

July 15, 2025 07:52

AA-Turner added the needs backport to 3.14 bugs and security fixes label

Jul 15, 2025

lysnikolaou approved these changes

Jul 15, 2025

View reviewed changes

lysnikolaou left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @AA-Turner!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot added awaiting merge and removed awaiting core review labels

Jul 15, 2025

lysnikolaou merged commit 5b969fd into python:main

Jul 15, 2025

bedevere-app Bot removed the awaiting merge label

Jul 15, 2025

miss-islington-app Bot commented Jul 15, 2025

Copy link

Copy Markdown

Thanks @AA-Turner for the PR, and @lysnikolaou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jul 15, 2025


          pythonGH-132661: Add string.templatelib.convert() (pythonGH-135217)

d0e51ee

(cherry picked from commit 5b969fd)

Co-authored-by: Adam Turner <[email protected]>

bedevere-app Bot commented Jul 15, 2025

Copy link

Copy Markdown

GH-136671 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AA-Turner deleted the templatelib-convert branch

July 15, 2025 09:57

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label

Jul 15, 2025

AA-Turner mentioned this pull request

Jul 15, 2025

[3.14] GH-132661: Add string.templatelib.convert() (GH-135217) #136671

Merged

AA-Turner added a commit that referenced this pull request

Jul 15, 2025


          [3.14] GH-132661: Add string.templatelib.convert() (GH-135217) (#…

2ae0eb1

…136671)

GH-132661: Add ``string.templatelib.convert()`` (GH-135217)
(cherry picked from commit 5b969fd)

Co-authored-by: Adam Turner <[email protected]>

davepeck commented Jul 15, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

🎉 Thanks, @AA-Turner ! I'll add docs for this to #135229

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request

Aug 4, 2025


          pythonGH-132661: Add string.templatelib.convert() (python#135217)

3f1d46f

Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request

Aug 19, 2025


          pythonGH-132661: Add string.templatelib.convert() (python#135217)

81c76f3

kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request

Sep 9, 2025


          [3.14] pythonGH-132661: Add string.templatelib.convert() (pythonG…

dfaf183

…H-135217) (python#136671)

pythonGH-132661: Add ``string.templatelib.convert()`` (pythonGH-135217)
(cherry picked from commit 5b969fd)

Co-authored-by: Adam Turner <[email protected]>

NickCrews added a commit to NickCrews/tstrings-backport that referenced this pull request

Mar 11, 2026


          feat: backport convert() function for API compatibility

8cb9ec9

This was implemented upstream in python/cpython#135217

NickCrews mentioned this pull request

Mar 11, 2026

feat: backport convert() function for API compatibility abilian/tstrings-backport#15

Open

Reviewers

lysnikolaou

lysnikolaou approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

AA-Turner commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lysnikolaou commented Jul 10, 2025

Uh oh!

lysnikolaou left a comment

Choose a reason for hiding this comment

Uh oh!

hugovk commented Jul 11, 2025

Uh oh!

lysnikolaou commented Jul 15, 2025

Uh oh!

AA-Turner commented Jul 15, 2025

Uh oh!

lysnikolaou left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington-app Bot commented Jul 15, 2025

Uh oh!

bedevere-app Bot commented Jul 15, 2025

Uh oh!

davepeck commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

AA-Turner commented Jun 6, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

davepeck commented Jul 15, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.