GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix warnings `set but not used [-Wunused-but-set-variable]` in remote_debug.h by chris-eibl · Pull Request #135290 · python/cpython

Conversation

@chris-eibl

@chris-eibl chris-eibl commented Jun 9, 2025

Copy link
Copy Markdown
Member

Since #134682 these warnings

Python/remote_debug.h:677:9: warning: variable 'lines_processed' set but not used [-Wunused-but-set-variable]
Python/remote_debug.h:678:9: warning: variable 'matches_found' set but not used [-Wunused-but-set-variable]

show up on build bots, e.g. https://buildbot.python.org/#/builders/441/builds/8081.

Likewise, I see similar warnings in clang-cl based builds on Windows (#131296):

..\Python\remote_debug.h(843,9): warning : variable 'modules_examined' set but not used [-Wunused-but-set-variable] [e:\cpython_clang\PCbuild\pythoncore.vcxproj]
..\Python\remote_debug.h(844,9): warning : variable 'matches_found' set but not used [-Wunused-but-set-variable] [e:\cpython_clang\PCbuild\pythoncore.vcxproj]

@pablogsal I think this is a skip news and a skip issue (even though it should be backported to 3.14)?
Or shall/can I link it to #91048?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@chris-eibl
fix "set but not used [-Wunused-but-set-variable]" warnings
6981ea4
@chris-eibl
chris-eibl requested a review from pablogsal as a code owner June 9, 2025 08:10
@bedevere-app bedevere-app Bot added the awaiting review label Jun 9, 2025
@chris-eibl chris-eibl added skip issue skip news labels Jun 9, 2025
pablogsal
pablogsal approved these changes Jun 10, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jun 10, 2025
@pablogsal pablogsal added needs backport to 3.14 bugs and security fixes and removed awaiting merge labels Jun 10, 2025
@pablogsal

pablogsal commented Jun 10, 2025

Copy link
Copy Markdown
Member

@pablogsal I think this is a skip news and a skip issue (even though it should be backported to 3.14)?

Correct!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
pablogsal merged commit 49fc1f2 into python:main Jun 10, 2025
@miss-islington-app

miss-islington-app Bot commented Jun 10, 2025

Copy link
Copy Markdown

Thanks @chris-eibl for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 10, 2025
@chris-eibl @miss-islington
Fix warnings set but not used [-Wunused-but-set-variable] in remote…
1259866 
…_debug.h (pythonGH-135290)

(cherry picked from commit 49fc1f2)

Co-authored-by: Chris Eibl <[email protected]>
@bedevere-app

bedevere-app Bot commented Jun 10, 2025

Copy link
Copy Markdown

GH-135319 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 10, 2025
@pablogsal

pablogsal commented Jun 10, 2025

Copy link
Copy Markdown
Member

Thanks a lot for the fix @chris-eibl 🚀
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pablogsal pushed a commit that referenced this pull request Jun 10, 2025
@miss-islington @chris-eibl
[3.14] Fix warnings set but not used [-Wunused-but-set-variable] in…
84c6fe6 
… remote_debug.h (GH-135290) (#135319)

Fix warnings `set but not used [-Wunused-but-set-variable]` in remote_debug.h (GH-135290)
(cherry picked from commit 49fc1f2)

Co-authored-by: Chris Eibl <[email protected]>
@chris-eibl
chris-eibl deleted the fix_remote_debug_warnings branch June 10, 2025 05:00
lkollar pushed a commit to lkollar/cpython that referenced this pull request Jun 19, 2025
@chris-eibl @lkollar
Fix warnings set but not used [-Wunused-but-set-variable] in remote…
b52c259 
…_debug.h (python#135290)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@chris-eibl @Pranjal095
Fix warnings set but not used [-Wunused-but-set-variable] in remote…
160bf4c 
…_debug.h (python#135290)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@chris-eibl @taegyunkim
Fix warnings set but not used [-Wunused-but-set-variable] in remote…
ce98cbf 
…_debug.h (python#135290)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@chris-eibl @Agent-Hellboy
Fix warnings set but not used [-Wunused-but-set-variable] in remote…
be15ab5 
…_debug.h (python#135290)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@chris-eibl @pablogsal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.