GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-133390: Support SQL keyword completion for sqlite3 CLI (#133393) by encukou · Pull Request #135292 · python/cpython

Conversation

@encukou

@encukou encukou commented Jun 9, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Support completion for sqlite3 command-line interface #133390

📚 Documentation preview 📚: https://cpython-previews--135292.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tanloong @encukou
pythongh-133390: Support SQL keyword completion for sqlite3 CLI (pyth…
10f822b 
…on#133393)
@encukou
encukou requested review from berkerpeksag and erlend-aasland as code owners June 9, 2025 09:39
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 9, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jun 9, 2025
Support completion for sqlite3 command-line interface #133390
Closed
@encukou

encukou commented Jun 9, 2025

Copy link
Copy Markdown
Member Author

!buildbot aarch64.Fedora.Stable.PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jun 9, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit 10f822b 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135292%2Fmerge

The command will test the builders whose names match following regular expression: aarch64.Fedora.Stable.PR

The builders matched are:

  • aarch64 Fedora Stable PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
encukou added 2 commits June 9, 2025 11:58
@encukou
Pass env variables to test subprocess
a59ec6a
@encukou
Import unittest.mock, so test_sqlite3.test_cli works on its own
bd6a870
@encukou

encukou commented Jun 9, 2025

Copy link
Copy Markdown
Member Author

!buildbot aarch64.Fedora.Stable.PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jun 9, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit bd6a870 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135292%2Fmerge

The command will test the builders whose names match following regular expression: aarch64.Fedora.Stable.PR

The builders matched are:

  • aarch64 Fedora Stable PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou

encukou commented Jun 9, 2025

Copy link
Copy Markdown
Member Author

!buildbot AMD64.Ubuntu.Shared.PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jun 9, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit bd6a870 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135292%2Fmerge

The command will test the builders whose names match following regular expression: AMD64.Ubuntu.Shared.PR

The builders matched are:

  • AMD64 Ubuntu Shared PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou
Dump output on error in verbose mode
3d9721a
@encukou

encukou commented Jun 10, 2025

Copy link
Copy Markdown
Member Author

!buildbot AMD64.Ubuntu.Shared.PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jun 10, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit 3d9721a 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135292%2Fmerge

The command will test the builders whose names match following regular expression: AMD64.Ubuntu.Shared.PR

The builders matched are:

  • AMD64 Ubuntu Shared PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou
Disable readline's show-all settings
f1fa6c7
@encukou

encukou commented Jun 11, 2025

Copy link
Copy Markdown
Member Author

!buildbot AMD64.Ubuntu.Shared.PR|aarch64.Fedora.Stable.PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jun 11, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit f1fa6c7 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135292%2Fmerge

The command will test the builders whose names match following regular expression: AMD64.Ubuntu.Shared.PR|aarch64.Fedora.Stable.PR

The builders matched are:

  • AMD64 Ubuntu Shared PR
  • aarch64 Fedora Stable PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 11, 2025
@bedevere-bot

bedevere-bot commented Jun 11, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit f1fa6c7 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135292%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 11, 2025
@encukou

encukou commented Jun 12, 2025

Copy link
Copy Markdown
Member Author

Alright, looks like we now pass everywhere!

  • In some configurations, Python needs some env variables to start, so the environment needs to be updated rather than replaced.
  • The show-all-if-ambiguous readline setting means that alternatives are listed after a single tab, so with \t\t they got listed twice.
tanloong reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou
encukou merged commit e7a3c20 into python:main Jun 12, 2025
@bedevere-app bedevere-app Bot removed the awaiting core review label Jun 12, 2025
@encukou
encukou deleted the reapply-62b3d2d branch June 12, 2025 14:28
erlend-aasland
erlend-aasland reviewed Jun 13, 2025
View reviewed changes
Comment thread Lib/test/test_sqlite3/test_cli.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
lkollar pushed a commit to lkollar/cpython that referenced this pull request Jun 19, 2025
@encukou @tanloong @lkollar
pythongh-133390: Support SQL keyword completion for sqlite3 CLI (pyth…
6767d02 
…onGH-133393) (pythonGH-135292)

Co-authored-by: Tan Long <[email protected]>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@encukou @tanloong @Pranjal095
pythongh-133390: Support SQL keyword completion for sqlite3 CLI (pyth…
23f7b0e 
…onGH-133393) (pythonGH-135292)

Co-authored-by: Tan Long <[email protected]>
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@encukou @tanloong @taegyunkim
pythongh-133390: Support SQL keyword completion for sqlite3 CLI (pyth…
21bea1b 
…onGH-133393) (pythonGH-135292)

Co-authored-by: Tan Long <[email protected]>
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@encukou @tanloong @Agent-Hellboy
pythongh-133390: Support SQL keyword completion for sqlite3 CLI (pyth…
c2661a6 
…onGH-133393) (pythonGH-135292)

Co-authored-by: Tan Long <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland left review comments
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@encukou @bedevere-bot @erlend-aasland @tanloong
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.