GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-135422: Fix regression in `SyntaxError` messages after #134036 by sobolevn · Pull Request #135423 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Jun 12, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Invalid error messages after GH-134077 #135422

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-135422: Fix regression in SyntaxError messages after pytho…
0d94e64 
…n#134036
@sobolevn
sobolevn requested review from lysnikolaou and pablogsal as code owners June 12, 2025 08:20
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 12, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jun 12, 2025
Invalid error messages after GH-134077 #135422
Closed
efimov-mikhail
efimov-mikhail approved these changes Jun 13, 2025
View reviewed changes

@efimov-mikhail efimov-mikhail left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@efimov-mikhail

efimov-mikhail commented Jun 13, 2025

Copy link
Copy Markdown
Member

FYI, I've tested this locally before the review.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lysnikolaou
lysnikolaou approved these changes Jun 30, 2025
View reviewed changes

@lysnikolaou lysnikolaou left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @sobolevn!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jun 30, 2025
@sobolevn
sobolevn merged commit 7e33558 into python:main Jun 30, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 30, 2025
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
@sobolevn @AndPuQing
pythongh-135422: Fix regression in SyntaxError messages after pytho…
88c9480 
…n#134036 (python#135423)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@sobolevn @Pranjal095
pythongh-135422: Fix regression in SyntaxError messages after pytho…
27a5841 
…n#134036 (python#135423)
picnixz pushed a commit to picnixz/cpython that referenced this pull request Jul 13, 2025
@sobolevn @picnixz
pythongh-135422: Fix regression in SyntaxError messages after pytho…
24a2572 
…n#134036 (python#135423)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@sobolevn @taegyunkim
pythongh-135422: Fix regression in SyntaxError messages after pytho…
94599d6 
…n#134036 (python#135423)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@sobolevn @Agent-Hellboy
pythongh-135422: Fix regression in SyntaxError messages after pytho…
2c13c88 
…n#134036 (python#135423)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efimov-mikhail efimov-mikhail efimov-mikhail approved these changes
@lysnikolaou lysnikolaou lysnikolaou approved these changes
@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sobolevn @efimov-mikhail @lysnikolaou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.