GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-135444: fix DatagramTransport buffer_size accounting by jsbronder · Pull Request #135445 · python/cpython

Conversation

@jsbronder

@jsbronder jsbronder commented Jun 12, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Commit 73e8637 added 8 to the buffer_size when send could not be called right away. However, it did not complete this accounting by removing 8 from the buffer size when sending did finally complete.

  • Issue: 3.13 asyncio DatagramTransport buffer size accounting regression. #135444

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jsbronder
jsbronder requested review from 1st1, asvetlov, kumaraditya303 and willingc as code owners June 12, 2025 19:54
@bedevere-app bedevere-app Bot added the awaiting review label Jun 12, 2025
@bedevere-app

bedevere-app Bot commented Jun 12, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot mentioned this pull request Jun 12, 2025
3.13 asyncio DatagramTransport buffer size accounting regression. #135444
Closed
@jsbronder
jsbronder force-pushed the dgram-accounting branch from 04c6560 to 8a8f749 Compare June 12, 2025 21:45
@bedevere-app

bedevere-app Bot commented Jun 12, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jsbronder
jsbronder force-pushed the dgram-accounting branch from 8a8f749 to 860cec6 Compare June 16, 2025 16:37
jsbronder added a commit to jsbronder/asyncio-dgram that referenced this pull request Jul 7, 2025
@jsbronder
test: skip pause/resume test on python 3.13 and greater
4b116de 
Accounting in asyncio.DatagramTransport is broken, so this won't pass.
python/cpython#135444
python/cpython#135445
@jsbronder jsbronder mentioned this pull request Jul 7, 2025
workaround upstream bug in asyncio.DatagramTransport flow control accounting jsbronder/asyncio-dgram#22
Merged
jsbronder added a commit to jsbronder/asyncio-dgram that referenced this pull request Jul 7, 2025
@jsbronder
test: skip pause/resume test on python 3.13 and greater
d7be8b0 
Accounting in asyncio.DatagramTransport is broken, so this won't pass.
python/cpython#135444
python/cpython#135445
@kumaraditya303
kumaraditya303 requested a review from gvanrossum July 26, 2025 10:44
@kumaraditya303 kumaraditya303 added type-bug An unexpected behavior, bug, or error topic-asyncio needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Jul 26, 2025
kumaraditya303
kumaraditya303 reviewed Jul 26, 2025
View reviewed changes
Comment thread Lib/test/test_asyncio/test_selector_events.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
kumaraditya303
kumaraditya303 reviewed Jul 26, 2025
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2025-06-16-12-37-02.gh-issue-135444.An2eeA.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@jsbronder
pythongh-135444: fix DatagramTransport buffer_size accounting
f661a57 
Commit 73e8637 added 8 to the
buffer_size when send could not be called right away.  However, it did
not complete this accounting by removing 8 from the buffer size when
sending did finally complete.
@jsbronder
jsbronder force-pushed the dgram-accounting branch from 860cec6 to f661a57 Compare July 29, 2025 17:51
kumaraditya303
kumaraditya303 reviewed Jul 30, 2025
View reviewed changes
Comment thread Lib/test/test_asyncio/test_selector_events.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
kumaraditya303
kumaraditya303 reviewed Jul 30, 2025
View reviewed changes
Comment thread Lib/test/test_asyncio/test_selector_events.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
kumaraditya303 added 2 commits July 30, 2025 20:44
@kumaraditya303
Update Lib/test/test_asyncio/test_selector_events.py
71f8aaf
@kumaraditya303
Update Lib/test/test_asyncio/test_selector_events.py
bc204cd
kumaraditya303
kumaraditya303 approved these changes Jul 30, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jul 30, 2025
@kumaraditya303
kumaraditya303 merged commit e3ea861 into python:main Jul 30, 2025
@miss-islington-app

miss-islington-app Bot commented Jul 30, 2025

Copy link
Copy Markdown

Thanks @jsbronder for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 30, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 30, 2025
@jsbronder @kumaraditya303 @miss-islington
pythongh-135444: fix asyncio.DatagramTransport.sendto to account fo…
63c6c0f 
…r datagram header size when data cannot be sent (pythonGH-135445)

(cherry picked from commit e3ea861)

Co-authored-by: Justin Bronder <[email protected]>
Co-authored-by: Kumar Aditya <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 30, 2025
@jsbronder @kumaraditya303 @miss-islington
pythongh-135444: fix asyncio.DatagramTransport.sendto to account fo…
9205e2b 
…r datagram header size when data cannot be sent (pythonGH-135445)

(cherry picked from commit e3ea861)

Co-authored-by: Justin Bronder <[email protected]>
Co-authored-by: Kumar Aditya <[email protected]>
@bedevere-app

bedevere-app Bot commented Jul 30, 2025

Copy link
Copy Markdown

GH-137245 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 30, 2025
@bedevere-app

bedevere-app Bot commented Jul 30, 2025

Copy link
Copy Markdown

GH-137246 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jul 30, 2025
kumaraditya303 added a commit that referenced this pull request Aug 3, 2025
@miss-islington @jsbronder @kumaraditya303
[3.13] gh-135444: fix asyncio.DatagramTransport.sendto to account f…
1b0dfbf 
…or datagram header size when data cannot be sent (GH-135445) (#137246)

gh-135444: fix `asyncio.DatagramTransport.sendto` to account for datagram header size when data cannot be sent (GH-135445)
(cherry picked from commit e3ea861)

Co-authored-by: Justin Bronder <[email protected]>
Co-authored-by: Kumar Aditya <[email protected]>
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@jsbronder @kumaraditya303 @Agent-Hellboy
pythongh-135444: fix asyncio.DatagramTransport.sendto to account fo…
7f10c29 
…r datagram header size when data cannot be sent (python#135445)

Co-authored-by: Kumar Aditya <[email protected]>
kumaraditya303 added a commit that referenced this pull request Oct 7, 2025
@miss-islington @jsbronder @kumaraditya303
[3.14] gh-135444: fix asyncio.DatagramTransport.sendto to account f…
93ac6f3 
…or datagram header size when data cannot be sent (GH-135445) (#137245)

gh-135444: fix `asyncio.DatagramTransport.sendto` to account for datagram header size when data cannot be sent (GH-135445)
(cherry picked from commit e3ea861)

Co-authored-by: Justin Bronder <[email protected]>
Co-authored-by: Kumar Aditya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-asyncio type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jsbronder @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.