GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-21536: Follow-up to #13549 by embray · Pull Request #13552 · python/cpython

Conversation

@embray

@embray embray commented May 24, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This test in #13549 was not correct. I rewrote it a bit more clearly. This is necessary for python-config to work properly on Cygwin.

I also added a small fix to a (trivial) bug I noticed in configure. @vstinner

https://bugs.python.org/issue21536

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
embray added 2 commits May 24, 2019 18:13
@embray
Fix this test and invert the sense of it somewhat so that it's clearer
9fc56cc 
(positive propositions instead of negative).
@embray
Add missing AC_MSG_RESULT for AC_MSG_CHECKING(MACHDEP)
5924bca
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 24, 2019
@bedevere-bot bedevere-bot added the awaiting review label May 24, 2019
@vstinner vstinner added the skip news label May 24, 2019
@vstinner
vstinner merged commit b1fc417 into python:master May 24, 2019
@bedevere-bot bedevere-bot removed the awaiting review label May 24, 2019
@vstinner

vstinner commented May 24, 2019

Copy link
Copy Markdown
Member

Merged, thanks again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@embray @DinoV
bpo-21536: Fix configure.ac for LIBPYTHON on Android/Cygwin (pythonGH…
97a420b 
…-13552)

Add also missing AC_MSG_RESULT for AC_MSG_CHECKING(MACHDEP).
@pitrou pitrou mentioned this pull request Sep 2, 2022
extension built with a shared python cannot be loaded with a static python #65735
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@embray @vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.