GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-65697: Improved error msg for configparser key validation by lincolnj1 · Pull Request #135527 · python/cpython

Conversation

lincolnj1 commented Jun 15, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

In 3.14, I updated the configparser to validate keys before writing them due to security concerns. As mentioned in recent discussion on gh-65697, this error message isn't terribly helpful and users didn't know that the change had been implemented at all. This change will let the user know which key (and potentially delimiter) caused an InvalidWriteError and also adds a note in the 3.14 whatsnew so that users will know about the previous change.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

lincolnj1 added 2 commits

June 14, 2025 19:47


          Improved error msg for configparser key validation and added note in …

fdd2453

…3.14 whatsnew


          Properly added change to configparser

1c04d28

lincolnj1 requested a review from jaraco as a code owner

June 15, 2025 02:56

bedevere-app Bot added the awaiting review label

Jun 15, 2025

lincolnj1 changed the title ~~gh- 65697: Improved error msg for configparser key validation and added note in …~~ gh- 65697: Improved error msg for configparser key validation

Jun 15, 2025

lincolnj1 changed the title ~~gh- 65697: Improved error msg for configparser key validation~~ gh-65697: Improved error msg for configparser key validation

Jun 15, 2025

bedevere-app Bot mentioned this pull request

Jun 15, 2025

configparser accepts invalid keys and sections when writing #65697

Open


          📜🤖 Added by blurb_it.

14b4ed9

jaraco added 3.14

bugs and security fixes

needs backport to 3.14 bugs and security fixes and removed 3.14 bugs and security fixes labels

Jun 15, 2025

jaraco approved these changes

Jun 15, 2025

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting review labels

Jun 15, 2025

jaraco commented Jun 15, 2025

Copy link

Copy Markdown

Member

Nicely done. Thanks.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jaraco merged commit 81237fb into python:main

Jun 15, 2025

miss-islington-app Bot commented Jun 15, 2025

Copy link

Copy Markdown

Thanks @lincolnj1 for the PR, and @jaraco for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting merge label

Jun 15, 2025

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jun 15, 2025


          pythongh-65697: Improved error msg for configparser key validation (p…

8a52725

…ythonGH-135527)

* Improved error msg for configparser key validation and added note in 3.14 whatsnew

* Properly added change to configparser

* 📜🤖 Added by blurb_it.

---------
(cherry picked from commit 81237fb)

Co-authored-by: Jacob Austin Lincoln <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>

bedevere-app Bot commented Jun 15, 2025

Copy link

Copy Markdown

GH-135541 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label

Jun 15, 2025

jaraco pushed a commit that referenced this pull request

Jun 15, 2025


          [3.14] gh-65697: Improved error msg for configparser key validation (G…

6ae5455

…H-135527) (#135541)

gh-65697: Improved error msg for configparser key validation (GH-135527)

* Improved error msg for configparser key validation and added note in 3.14 whatsnew

* Properly added change to configparser

* 📜🤖 Added by blurb_it.

---------
(cherry picked from commit 81237fb)

Co-authored-by: Jacob Austin Lincoln <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>

shuimu5418 pushed a commit to shuimu5418/cpython001 that referenced this pull request

Jun 16, 2025


          pythongh-65697: Improved error msg for configparser key validation (p…

2e71605

…ython#135527)

* Improved error msg for configparser key validation and added note in 3.14 whatsnew

* Properly added change to configparser

* 📜🤖 Added by blurb_it.

---------

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>

lkollar pushed a commit to lkollar/cpython that referenced this pull request

Jun 19, 2025


          pythongh-65697: Improved error msg for configparser key validation (p…

…ython#135527)

* Improved error msg for configparser key validation and added note in 3.14 whatsnew

* Properly added change to configparser

* 📜🤖 Added by blurb_it.

---------

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>

Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request

Jul 12, 2025


          pythongh-65697: Improved error msg for configparser key validation (p…

26e7938

…ython#135527)

* Improved error msg for configparser key validation and added note in 3.14 whatsnew

* Properly added change to configparser

* 📜🤖 Added by blurb_it.

---------

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>

taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request

Aug 4, 2025


          pythongh-65697: Improved error msg for configparser key validation (p…

…ython#135527)

* Improved error msg for configparser key validation and added note in 3.14 whatsnew

* Properly added change to configparser

* 📜🤖 Added by blurb_it.

---------

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>

Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request

Aug 19, 2025


          pythongh-65697: Improved error msg for configparser key validation (p…

f3efc49

…ython#135527)

* Improved error msg for configparser key validation and added note in 3.14 whatsnew

* Properly added change to configparser

* 📜🤖 Added by blurb_it.

---------

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>

Reviewers

jaraco

jaraco approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

lincolnj1 commented Jun 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jaraco commented Jun 15, 2025

Uh oh!

miss-islington-app Bot commented Jun 15, 2025

Uh oh!

bedevere-app Bot commented Jun 15, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

lincolnj1 commented Jun 15, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.