GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-34632: fix installation of importlib.metadata by yan12125 · Pull Request #13563 · python/cpython

Conversation

@yan12125

@yan12125 yan12125 commented May 25, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

https://bugs.python.org/issue34632

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Chih-Hsuan Yen
bpo-34632: fix installation of importlib.metadata
b1b2caf
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 25, 2019
@bedevere-bot bedevere-bot added the awaiting review label May 25, 2019
@jaraco jaraco added the skip news label May 25, 2019
@jaraco

jaraco commented May 25, 2019

Copy link
Copy Markdown
Member

Thank you @yan12125 for putting this together. I was unaware of this subtle footgun.
yan12125 reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jaraco
jaraco merged commit c3738cf into python:master May 25, 2019
@bedevere-bot

bedevere-bot commented May 25, 2019

Copy link
Copy Markdown

@jaraco: Please replace # with GH- in the commit message next time. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting review label May 25, 2019
@yan12125
yan12125 deleted the fix-importlib-metadata-installation branch May 25, 2019 08:14
@jaraco jaraco mentioned this pull request May 25, 2019
bpo-34632 fix buildbots and remove artifact #13566
Merged
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
Chih-Hsuan Yen @DinoV
bpo-34632: fix installation of importlib.metadata (python#13563)
e262521
@jaraco jaraco mentioned this pull request Dec 31, 2021
bpo-46118: Make sure importlib.resources is included. #30311
Merged
@encukou encukou mentioned this pull request Jun 27, 2022
Point out that new stdlib modules need to be added to Makefile.pre.in python/devguide#909
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@yan12125 @jaraco @bedevere-bot @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.